Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document update variants #317

Closed
morgante opened this issue Nov 13, 2019 · 2 comments · Fixed by #386
Closed

Document update variants #317

morgante opened this issue Nov 13, 2019 · 2 comments · Fixed by #386
Labels
enhancement New feature or request P3 medium priority issues triaged Scoped and ready for work

Comments

@morgante
Copy link
Contributor

In #256, we added support for node pools to be created before being destroyed in variants. We should provide documentation (in the respective READMEs) of what the update variants are useful for.

@morgante
Copy link
Contributor Author

Potential language to include:

The benefit is that you always have some node pools active. We don't actually cordon/drain the traffic beyond what the GKE API itself will do, but we do make sure the new node pool is created before the old one is destroyed. The implications of this are that:

  1. We append a random ID on the node pool names (since you can't have two simultaneously active node pools)
  2. For a brief period, you'll have 2x as many resources/node pools
  3. You will indeed need sufficient IP space (and compute capacity) to create both node pools

@ideasculptor
Copy link
Contributor

Documentation of what will happen when changing node pool configurations in the non-update variants is also necessary, as I just discovered the hard way.

@aaron-lane aaron-lane added enhancement New feature or request triaged Scoped and ready for work labels Nov 18, 2019
@aaron-lane aaron-lane added the P3 medium priority issues label Dec 19, 2019
kopachevsky added a commit to kopachevsky/terraform-google-kubernetes-engine that referenced this issue Dec 23, 2019
kopachevsky added a commit to kopachevsky/terraform-google-kubernetes-engine that referenced this issue Dec 30, 2019
kopachevsky added a commit to kopachevsky/terraform-google-kubernetes-engine that referenced this issue Dec 30, 2019
kopachevsky added a commit to kopachevsky/terraform-google-kubernetes-engine that referenced this issue Jan 9, 2020
kopachevsky added a commit to kopachevsky/terraform-google-kubernetes-engine that referenced this issue Jan 9, 2020
kopachevsky added a commit to kopachevsky/terraform-google-kubernetes-engine that referenced this issue Jan 10, 2020
morgante pushed a commit that referenced this issue Jan 22, 2020
kri5 pushed a commit to kri5/terraform-google-kubernetes-engine that referenced this issue Jan 27, 2020
CPL-markus pushed a commit to WALTER-GROUP/terraform-google-kubernetes-engine that referenced this issue Jul 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request P3 medium priority issues triaged Scoped and ready for work
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants