Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EKS 1.15 Support #776

Merged
merged 5 commits into from
Mar 11, 2020
Merged

EKS 1.15 Support #776

merged 5 commits into from
Mar 11, 2020

Conversation

sc250024
Copy link
Contributor

@sc250024 sc250024 commented Mar 11, 2020

PR o'clock

Description

Upgrading module to support EKS 1.15. Resolves issue #775.

Checklist

CHANGELOG.md Outdated Show resolved Hide resolved
Copy link
Contributor

@max-rocket-internet max-rocket-internet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

NICE! Thanks @sc250024

@max-rocket-internet max-rocket-internet merged commit 7dc56e9 into terraform-aws-modules:master Mar 11, 2020
@sc250024 sc250024 deleted the feat-Eks115 branch March 11, 2020 16:08
@abdennour
Copy link

Does tag "kubernetes.io/cluster/${local.cluster_name}" not compatible with EKS 1.15 ?
I am seeing a lot of removals of tags.

@sc250024
Copy link
Contributor Author

@abdennour Check out #775. The VPC tagging requirement is no longer needed for clusters with Kubernetes 1.15 and above. I removed those VPC tags from the examples since starting with v10.0.0 of this module they're no longer needed.

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 19, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants