Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add EKS Secret envelope encryption support #772

Merged

Conversation

wwentland
Copy link
Contributor

@wwentland wwentland commented Mar 10, 2020

PR o'clock

Description

This adds support for configuring EKS clusters that utilise envelope
encryption for Secrets:

This addresses #767

Checklist

@wwentland wwentland force-pushed the dev/kms-envelope-encryption branch 9 times, most recently from 1c0aa0d to a36731c Compare March 10, 2020 18:35
@barryib
Copy link
Member

barryib commented Mar 10, 2020

Thanks @babilen5 this is awesome. Can you please update your branch and resolve conflicts ?

@barryib barryib self-assigned this Mar 10, 2020
@wwentland wwentland force-pushed the dev/kms-envelope-encryption branch from a36731c to 228a192 Compare March 11, 2020 06:01
@wwentland
Copy link
Contributor Author

Can you please update your branch and resolve conflicts ?

Done, @barryib.

@wwentland wwentland force-pushed the dev/kms-envelope-encryption branch from 228a192 to 43f2523 Compare March 11, 2020 07:35
Copy link
Member

@barryib barryib left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor changes request otherwise it's LGTM.

variables.tf Outdated Show resolved Hide resolved
@wwentland wwentland force-pushed the dev/kms-envelope-encryption branch from 43f2523 to b526770 Compare March 11, 2020 10:53
@wwentland wwentland requested a review from barryib March 11, 2020 10:57
@barryib barryib merged commit 23c005e into terraform-aws-modules:master Mar 11, 2020
@wwentland wwentland deleted the dev/kms-envelope-encryption branch March 11, 2020 11:26
max-rocket-internet pushed a commit that referenced this pull request Mar 11, 2020
* chore(eks): Support EKS 1.15

* docs(changelog): Adding entry to CHANGELOG

* chore(examples): Removing VPC tags from merged PR #772

* docs(changelog): Adding 'breaking' to CHANGELOG entry
@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 19, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants