-
-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add ASG cooldown and health_check_grace_period #770
Conversation
@max-rocket-internet |
btw, while fixing my pr, i've noticed this https://github.com/terraform-aws-modules/terraform-aws-eks/blob/master/workers.tf#L77 |
Thanks @ArieLevs I was a bit tired yesternight. Fixing this. |
For the record, supersedes #751 |
Co-Authored-By: Thierno IB. BARRY <[email protected]>
Thanks @ArieLevs |
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further. |
PR o'clock
Description
Add default_cooldown
and health_check_grace_period
options
Checklist