Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ASG cooldown and health_check_grace_period #770

Merged
merged 3 commits into from
Mar 10, 2020
Merged

Add ASG cooldown and health_check_grace_period #770

merged 3 commits into from
Mar 10, 2020

Conversation

ArieLevs
Copy link
Contributor

@ArieLevs ArieLevs commented Mar 10, 2020

PR o'clock

Description

Add default_cooldown
and health_check_grace_period
options

Checklist

@ArieLevs
Copy link
Contributor Author

@max-rocket-internet
@barryib
Opened new PR

@ArieLevs
Copy link
Contributor Author

btw, while fixing my pr, i've noticed this https://github.com/terraform-aws-modules/terraform-aws-eks/blob/master/workers.tf#L77
shouldn't it be var.worker_groups[count.index], as well?

@barryib
Copy link
Member

barryib commented Mar 10, 2020

btw, while fixing my pr, i've noticed this https://github.com/terraform-aws-modules/terraform-aws-eks/blob/master/workers.tf#L77
shouldn't it be var.worker_groups[count.index], as well?

Thanks @ArieLevs I was a bit tired yesternight. Fixing this.

@barryib
Copy link
Member

barryib commented Mar 10, 2020

For the record, supersedes #751

CHANGELOG.md Outdated Show resolved Hide resolved
Co-Authored-By: Thierno IB. BARRY <[email protected]>
@barryib barryib merged commit f465e55 into terraform-aws-modules:master Mar 10, 2020
@barryib
Copy link
Member

barryib commented Mar 10, 2020

Thanks @ArieLevs

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 19, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants