Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ASG cooldown and health_check_grace_period options #751

Closed
wants to merge 7 commits into from
Closed

Conversation

ArieLevs
Copy link
Contributor

@ArieLevs ArieLevs commented Feb 26, 2020

PR o'clock

Description

Add default_cooldown
and health_check_grace_period
options

Checklist

@ArieLevs
Copy link
Contributor Author

@barryib @max-rocket-internet
Hi how can i get this PR get reviewed?

Copy link
Contributor

@max-rocket-internet max-rocket-internet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You also haven't updated the change log.

@max-rocket-internet
Copy link
Contributor

Screen Shot 2020-02-27 at 11 21 30

👈😃👈

@ArieLevs
Copy link
Contributor Author

@max-rocket-internet
Can you please look into this,
I cannot find a way to resolve conflicts from my side without reverting the commit on changelog

@ArieLevs
Copy link
Contributor Author

ArieLevs commented Mar 4, 2020

@max-rocket-internet
Hi,
Anything i can do to promote this?

@barryib
Copy link
Member

barryib commented Mar 9, 2020

@ArieLevs can you please update your branch and resolve conflits.

@ArieLevs
Copy link
Contributor Author

this PR is a total mess containing other files,
I'll just create a new one.

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 19, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants