fix: Not to iterate over remote_access object in dynamic block #1743
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
knight42
force-pushed
the
fix/eks-nodegroup-remote-access
branch
from
03f0620 to
3d8af0d
Compare
knight42
changed the title
bryantbiggs
reviewed
Jan 6, 2022
| @@ -295,7 +295,7 @@ resource "aws_eks_node_group" "this" { | |||
| } | |||
|
|
|||
| dynamic "remote_access" { | |||
| for_each = var.remote_access | |||
| for_each = length(var.remote_access) > 0 ? [var.remote_access] : [] | |||
There was a problem hiding this comment.
just testing locally looks like we also need to change lines 300-301 to:
ec2_ssh_key = try(remote_access.value.ec2_ssh_key, null)
source_security_group_ids = try(remote_access.value.source_security_group_ids, [])There was a problem hiding this comment.
Nice catch! I have applied your fix and verified it locally. Thanks!
knight42
force-pushed
the
fix/eks-nodegroup-remote-access
branch
from
3d8af0d to
c3d6c5b
Compare
bryantbiggs
approved these changes
Jan 7, 2022
antonbabenko
pushed a commit
that referenced
this pull request
Jan 7, 2022
### [18.0.4](v18.0.3...v18.0.4) (2022-01-07) ### Bug Fixes * Not to iterate over remote_access object in dynamic block ([#1743](#1743)) ([86b3c33](86b3c33))
|
This PR is included in version 18.0.4 🎉 |
baibailiha
added a commit
to baibailiha/terraform-aws-eks
that referenced
this pull request
Sep 13, 2022
### [18.0.4](terraform-aws-modules/terraform-aws-eks@v18.0.3...v18.0.4) (2022-01-07) ### Bug Fixes * Not to iterate over remote_access object in dynamic block ([#1743](terraform-aws-modules/terraform-aws-eks#1743)) ([ff8f236](terraform-aws-modules/terraform-aws-eks@ff8f236))
|
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Motivation and Context
Currently if user specifies
remote_accessineks_managed_node_groups, terraform will throw an error since we iterate theremote_accessobject directly, which is not expected.Breaking Changes
How Has This Been Tested?
examples/*projects