Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Not to iterate over remote_access object in dynamic block #1743

Merged
merged 1 commit into from
Jan 7, 2022
Merged

fix: Not to iterate over remote_access object in dynamic block #1743

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions examples/eks_managed_node_group/main.tf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -173,6 +173,10 @@ module "eks" {
}
]

remote_access = {
ec2_ssh_key = "my-ssh-key"
}

update_config = {
max_unavailable_percentage = 50 # or set `max_unavailable`
}
Expand Down
6 changes: 3 additions & 3 deletions modules/eks-managed-node-group/main.tf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -295,10 +295,10 @@ resource "aws_eks_node_group" "this" {
}

dynamic "remote_access" {
for_each = var.remote_access
for_each = length(var.remote_access) > 0 ? [var.remote_access] : []
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just testing locally looks like we also need to change lines 300-301 to:

	ec2_ssh_key               = try(remote_access.value.ec2_ssh_key, null)
	source_security_group_ids = try(remote_access.value.source_security_group_ids, [])

Copy link
Contributor Author

@knight42 knight42 Jan 7, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch! I have applied your fix and verified it locally. Thanks!

content {
ec2_ssh_key = lookup(remote_access.value, "ec2_ssh_key", null)
source_security_group_ids = lookup(remote_access.value, "source_security_group_ids", [])
ec2_ssh_key = try(remote_access.value.ec2_ssh_key, null)
source_security_group_ids = try(remote_access.value.source_security_group_ids, [])
}
}

Expand Down