fix: Not to iterate over remote_access object in dynamic block (#1743)

terraform-aws-modules · Jan 7, 2022 · 86b3c33 · 86b3c33
1 parent 3c66863
commit 86b3c33
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 3 deletions.
diff --git a/examples/eks_managed_node_group/main.tf b/examples/eks_managed_node_group/main.tf
@@ -173,6 +173,10 @@ module "eks" {
         }
       ]
 
+      remote_access = {
+        ec2_ssh_key = "my-ssh-key"
+      }
+
       update_config = {
         max_unavailable_percentage = 50 # or set `max_unavailable`
       }

diff --git a/modules/eks-managed-node-group/main.tf b/modules/eks-managed-node-group/main.tf
@@ -295,10 +295,10 @@ resource "aws_eks_node_group" "this" {
   }
 
   dynamic "remote_access" {
-    for_each = var.remote_access
+    for_each = length(var.remote_access) > 0 ? [var.remote_access] : []
     content {
-      ec2_ssh_key               = lookup(remote_access.value, "ec2_ssh_key", null)
-      source_security_group_ids = lookup(remote_access.value, "source_security_group_ids", [])
+      ec2_ssh_key               = try(remote_access.value.ec2_ssh_key, null)
+      source_security_group_ids = try(remote_access.value.source_security_group_ids, [])
     }
   }