Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add a new variable to control the creation of a lifecycle policy #4

Merged
merged 5 commits into from
Jun 13, 2022
Merged

feat: Add a new variable to control the creation of a lifecycle policy #4

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
64f2cd4
Add create_lifecycle_policy variable
phr3nzii Jun 11, 2022
95097c4
Add create_lifecycle_policy to the example and wrapper
phr3nzii Jun 11, 2022
51a98a7
Default to true for backward compatibility
phr3nzii Jun 13, 2022
760980d
Apply suggestions from code review
bryantbiggs Jun 13, 2022
de4a29b
fix: Add missing usage of `create_repository_policy` variable to poli…
bryantbiggs Jun 13, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -216,6 +216,7 @@ No modules.
| Name | Description | Type | Default | Required |
|------|-------------|------|---------|:--------:|
| <a name="input_create"></a> [create](#input\_create) | Determines whether resources will be created (affects all resources) | `bool` | `true` | no |
| <a name="input_create_lifecycle_policy"></a> [create\_lifecycle\_policy](#input\_create\_lifecycle\_policy) | Determines whether a lifecycle policy will be created | `bool` | `false` | no |
bryantbiggs marked this conversation as resolved.
Show resolved Hide resolved
| <a name="input_create_registry_policy"></a> [create\_registry\_policy](#input\_create\_registry\_policy) | Determines whether a registry policy will be created | `bool` | `false` | no |
| <a name="input_create_registry_replication_configuration"></a> [create\_registry\_replication\_configuration](#input\_create\_registry\_replication\_configuration) | Determines whether a registry replication configuration will be created | `bool` | `false` | no |
| <a name="input_create_repository"></a> [create\_repository](#input\_create\_repository) | Determines whether a repository will be created | `bool` | `true` | no |
Expand Down
1 change: 1 addition & 0 deletions examples/complete/main.tf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,6 +32,7 @@ module "ecr" {
repository_name = local.name

repository_read_write_access_arns = [data.aws_caller_identity.current.arn]
create_lifecycle_policy = true
repository_lifecycle_policy = jsonencode({
rules = [
{
Expand Down
2 changes: 1 addition & 1 deletion main.tf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -120,7 +120,7 @@ resource "aws_ecr_repository_policy" "this" {
################################################################################

resource "aws_ecr_lifecycle_policy" "this" {
count = local.create_private_repository ? 1 : 0
count = local.create_private_repository && var.create_lifecycle_policy ? 1 : 0

repository = aws_ecr_repository.this[0].name
policy = var.repository_lifecycle_policy
Expand Down
6 changes: 6 additions & 0 deletions variables.tf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -88,6 +88,12 @@ variable "repository_read_write_access_arns" {
# Lifecycle Policy
################################################################################

variable "create_lifecycle_policy" {
description = "Determines whether a lifecycle policy will be created"
type = bool
default = false
phr3nzii marked this conversation as resolved.
Show resolved Hide resolved
}

variable "repository_lifecycle_policy" {
description = "The policy document. This is a JSON formatted string. See more details about [Policy Parameters](http://docs.aws.amazon.com/AmazonECR/latest/userguide/LifecyclePolicies.html#lifecycle_policy_parameters) in the official AWS docs"
type = string
Expand Down
1 change: 1 addition & 0 deletions wrappers/main.tf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,7 @@ module "wrapper" {
create_repository_policy = try(each.value.create_repository_policy, var.defaults.create_repository_policy, true)
repository_read_access_arns = try(each.value.repository_read_access_arns, var.defaults.repository_read_access_arns, [])
repository_read_write_access_arns = try(each.value.repository_read_write_access_arns, var.defaults.repository_read_write_access_arns, [])
create_lifecycle_policy = try(each.value.create_lifecycle_policy, var.defaults.create_lifecycle_policy, false)
bryantbiggs marked this conversation as resolved.
Show resolved Hide resolved
repository_lifecycle_policy = try(each.value.repository_lifecycle_policy, var.defaults.repository_lifecycle_policy, "")
public_repository_catalog_data = try(each.value.public_repository_catalog_data, var.defaults.public_repository_catalog_data, {})
create_registry_policy = try(each.value.create_registry_policy, var.defaults.create_registry_policy, false)
Expand Down