feat: Add a new variable to control the creation of a lifecycle policy #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
phr3nzii
changed the title
bryantbiggs
requested changes
Jun 12, 2022
Co-authored-by: Bryant Biggs <[email protected]>
bryantbiggs
reviewed
Jun 13, 2022
bryantbiggs
reviewed
Jun 13, 2022
bryantbiggs
approved these changes
Jun 13, 2022
antonbabenko
pushed a commit
that referenced
this pull request
Jun 13, 2022
## [1.3.0](v1.2.0...v1.3.0) (2022-06-13) ### Features * Add a new variable to control the creation of a lifecycle policy ([#4](#4)) ([18c0515](18c0515))
|
This PR is included in version 1.3.0 🎉 |
|
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
create_lifecycle_policytotrueif you want a lifecycle policy to be created.create_repository_policyvariable to policy creationMotivation and Context
Sometimes a lifecycle policy isn't needed or wanted. This fixes #2
Closes #5
Breaking Changes
I wouldn't call this a breaking change. However, users who do want to have a lifecycle policy created will need to add the new variable to ensure that it is created.
How Has This Been Tested?
examples/*to demonstrate and validate my change(s)examples/*projectspre-commit run -aon my pull requestI have tested using the complete example by setting
create_lifecycle_policyto bothtrueandfalse. I've also updated this example to ensure that the lifecycle policy is created in future.I also tested this using the reproduction code from #2