Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use seconds as baseunit for duration metrics #6

Merged
merged 1 commit into from
Nov 21, 2020
Merged

use seconds as baseunit for duration metrics #6

merged 1 commit into from
Nov 21, 2020

Conversation

briend
Copy link
Contributor

@briend briend commented Nov 20, 2020

Trying to follow some suggested conventions:
https://prometheus.io/docs/practices/naming/

Will produce output like:

# HELP teraslice_query_duration_seconds Total time to complete the named query, in seconds.
# TYPE teraslice_query_duration_seconds gauge
teraslice_query_duration_seconds{query_name="info",url="https://ts-xxx/",name="teraslice-xxx"} 0.182
teraslice_query_duration_seconds{query_name="jobs",url="https://ts-xxx/",name="teraslice-xxx"} 0.251
teraslice_query_duration_seconds{query_name="controllers",url="https://ts-xxx/",name="teraslice-xxx"} 0.185
teraslice_query_duration_seconds{query_name="executions",url="https://ts-xxx/",name="teraslice-xxx"} 0.202503852
teraslice_query_duration_seconds{query_name="state",url="https://ts-xxx/",name="teraslice-xxx"} 0.18

the executions metric seems to have a bit more precision, but not sure if it's worth rounding for aesthetics.

closes #5

@godber
Copy link
Member

godber commented Nov 21, 2020

This looks good, I got a little clarification OOB.

@godber godber merged commit ccab5d3 into main Nov 21, 2020
@godber godber deleted the ms branch November 21, 2020 00:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Change the teraslice_query_duration value from ms to seconds
2 participants