Merge pull request #6 from terascope/ms

use seconds as baseunit for duration metrics
terascope · Nov 21, 2020 · ccab5d3 · ccab5d3
2 parents e215c41 + 2b70386
commit ccab5d3
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 7 deletions.
diff --git a/src/metrics.ts b/src/metrics.ts
@@ -89,8 +89,8 @@ const gaugeNumSlicers = new Gauge({
 });
 
 const gaugeQueryDuration = new Gauge({
-    name: `${metricPrefix}_query_duration`,
-    help: 'Total time to complete the named query, in ms.',
+    name: `${metricPrefix}_query_duration_seconds`,
+    help: 'Total time to complete the named query, in seconds.',
     labelNames: ['query_name', ...globalLabelNames],
     registers: [metricsRegistry],
 });

diff --git a/src/teraslice-stats.ts b/src/teraslice-stats.ts
@@ -84,7 +84,7 @@ export default class TerasliceStats implements TerasliceStatsInterface {
 
         const NS_PER_SEC = 1e9;
         const diff = process.hrtime(time);
-        this.queryDuration.executions = Math.round((diff[0] * NS_PER_SEC + diff[1]) / 1e6);
+        this.queryDuration.executions = (diff[0] * NS_PER_SEC + diff[1]) / 1e9;
     }
 
     // I think I've been doing this sort of thing wrong in the past.
@@ -105,10 +105,10 @@ export default class TerasliceStats implements TerasliceStatsInterface {
             this.state = state.data;
             await this.updateExecutions();
 
-            this.queryDuration.info = info.queryDuration;
-            this.queryDuration.jobs = jobs.queryDuration;
-            this.queryDuration.controllers = controllers.queryDuration;
-            this.queryDuration.state = state.queryDuration;
+            this.queryDuration.info = info.queryDuration / 1e3;
+            this.queryDuration.jobs = jobs.queryDuration / 1e3;
+            this.queryDuration.controllers = controllers.queryDuration / 1e3;
+            this.queryDuration.state = state.queryDuration / 1e3;
         };
         await run();
     }