Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove partition_assignment_strategy from kafka_sender and kafka_dead_letter #873

Open
busma13 opened this issue Nov 22, 2024 · 0 comments
Assignees

Comments

@busma13
Copy link
Contributor

busma13 commented Nov 22, 2024

The kafka_sender and kafka_dead_letter both have partition_assignment_strategy as a field in their configs. This option is only applicable to the kafka_reader and needs to be removed.

godber pushed a commit that referenced this issue Dec 6, 2024
…reader (#882)

This PR makes the following changes:

- Bump the kafka-asset version from 5.3.0 to 5.4.0
- Update the `kafka_reader` and `kafka_reader_api` to allow for
`cooperative-sticky` as a `partition_assignment_strategy` option.
- Set `minimum_teraslice_version` to 2.9.0, as this version uses
node-rdkafka v3.2.0, which is the first version to allow for incremental
rebalancing using `cooperative-sticky`.
- Remove `partition_assignment_strategy` option from `kafka_sender`,
`kafka_sender_api` and `kafka_dead_letter`. It looks like these might
have been copy/paste errors, as this is not a valid property on a kafka
producer config.

Ref: #869, #873
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants