-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update node-rdkafka to v3.2.0 #869
Comments
On question we need to answer is how is this cooperative rebalance behavior triggered, then we need to test whether it works in our high-volume scenarios. I this these are clues:
|
Then we just need to update each operation in a job to set the |
|
…reader (#882) This PR makes the following changes: - Bump the kafka-asset version from 5.3.0 to 5.4.0 - Update the `kafka_reader` and `kafka_reader_api` to allow for `cooperative-sticky` as a `partition_assignment_strategy` option. - Set `minimum_teraslice_version` to 2.9.0, as this version uses node-rdkafka v3.2.0, which is the first version to allow for incremental rebalancing using `cooperative-sticky`. - Remove `partition_assignment_strategy` option from `kafka_sender`, `kafka_sender_api` and `kafka_dead_letter`. It looks like these might have been copy/paste errors, as this is not a valid property on a kafka producer config. Ref: #869, #873
We should update to this:
https://github.com/Blizzard/node-rdkafka/releases/tag/v3.2.0
It in turn updates to
librdkafka
2.6.0: Blizzard/node-rdkafka#1103We should bump the minor version on our asset and make sure to update the terafoundation_kafka_connector version in the base image.
The text was updated successfully, but these errors were encountered: