fix: tensor class import for hermes #7947
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paradite
changed the title
|
/gcbrun |
|
Hi @pyu10055 the CI passed but merging requires linear history so I merged master into the branch. Let me know if it is okay for me to update, or tfjs team can help to update the PR. |
|
Hi @pyu10055 can help to review the PR? More people are experiencing the issue. Thanks! |
|
hi @mattsoulanille @pyu10055, please help to review the PR. It would help with people using React Native which is using hermes by default now: https://reactnative.dev/docs/hermes
Others are also reporting the issue: #7977 |
|
/gcbrun |
|
@pyu10055 Please take a look when you get a chance. Thanks! |
pyu10055
approved these changes
Oct 10, 2023
|
/gcbrun |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #6526 using suggestion in #5972 (comment)
The fix has been verified using my reproduction repo: https://github.com/paradite/tfjs-hermes-bug
To see the logs from the Cloud Build CI, please join either our discussion or announcement mailing list.