-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update tfjs-react-native to use tfjs 4.2.0 #7415
base: master
Are you sure you want to change the base?
Conversation
750a521
to
12b5cc1
Compare
Just wanted to let you know that me and my team (from DWS Brazil) are very excited with this update. I'm not sure how you guys work of if there's any other way to show the engagement for this merge (if there is, let me know!) And also if there's anything that us as a community can help you with this update. Thanks! |
Hi, @mattsoulanille. Sorry to bother you, but are there any updates on this PR? We are really looking forward to this merge so we can upgrade our app and release it. |
Hi @mattsoulanille. I noticed that this PR has been in draft for some time and you plan to split it up into two PRs. I have been using tfjs in production with various Expo versions for the past few months using my forked I believe indeed to get tfjs working with latest Expo it should be a simple change in |
@paradite, If you're willing to do that, I would happily review and merge that PR! To be perfectly honest, our team lacks the expertise to properly support React Native, particularly around native dependencies, and we've been hoping someone in the community might be able to help us there. Thank you! |
Hi @mattsoulanille, thanks for the reply. Upon a closer look, your PR #7451 has already fixed Based on my testing, there are a few more outstanding issues to get tfjs working on React Native:
For 1, my previous PR #7947 should fix them, just waiting for the next release For 2 and 3, I am plan to open two separate PRs to fix them (since 3 is a big change): First PR:
Second PR:
|
Add missing function for
isTypedArray
toplatform_react_native.ts
. Update tfjs, react native, and expo dependencies.Update the integration tests app to use expo and the latest version of react native.
Fixes #7323
TODO: Update the app CI before merging this.
Edit: I will split this PR into two PRs. One that updates the dependencies that do not require new native modules and one that updates the app's native modules.
To see the logs from the Cloud Build CI, please join either our discussion or announcement mailing list.
This change is