Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade global build param from C++11 to C++17 #7268

Merged
merged 6 commits into from
Jan 19, 2023
Merged

Upgrade global build param from C++11 to C++17 #7268

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
d7ccaa4
Add DenseBincount kernel
chunnienc Jan 12, 2023
bef8a61
Remove redundant checks
chunnienc Jan 12, 2023
eb9c5a2
Reduce buf reset calls
chunnienc Jan 12, 2023
8f32e70
Update to C++17
chunnienc Jan 12, 2023
d33862f
Merge branch 'master' into bazel-cpp17
chunnienc Jan 19, 2023
be1f152
fix
chunnienc Jan 19, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .bazelrc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ build --symlink_prefix=dist/

# These compile flags are active no matter which build mode we are in
# (dbg vs opt). For flags specific to build mode, see cc_toolchain_config.bzl.
build --cxxopt="-std=c++11"
build --cxxopt="-std=c++17"
build --cxxopt="-fno-rtti"
build --cxxopt="-fno-exceptions"
build --cxxopt="-fomit-frame-pointer"
Expand Down
6 changes: 2 additions & 4 deletions tfjs-backend-wasm/src/cc/kernels/DenseBincount.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,8 +23,7 @@
#include "tfjs-backend-wasm/src/cc/backend.h"
#include "tfjs-backend-wasm/src/cc/util.h"

namespace tfjs {
namespace wasm {
namespace tfjs::wasm {

namespace {

Expand Down Expand Up @@ -137,5 +136,4 @@ void DenseBincount(const int32_t x_id, const int32_t* x_shape_ptr,
}

} // extern "C"
} // namespace wasm
} // namespace tfjs
} // namespace tfjs::wasm