Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade global build param from C++11 to C++17 #7268

Merged
merged 6 commits into from
Jan 19, 2023

Conversation

chunnienc
Copy link
Collaborator

@chunnienc chunnienc commented Jan 12, 2023

To see the logs from the Cloud Build CI, please join either our discussion or announcement mailing list.


This change is Reviewable

@chunnienc chunnienc force-pushed the bazel-cpp17 branch 2 times, most recently from 5c03bd8 to 8f32e70 Compare January 19, 2023 18:03
@chunnienc chunnienc changed the title (WIP) Upgrade global build param from C++11 to C++17 Upgrade global build param from C++11 to C++17 Jan 19, 2023
@chunnienc chunnienc marked this pull request as ready for review January 19, 2023 18:06
Copy link
Member

@mattsoulanille mattsoulanille left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@chunnienc chunnienc merged commit da1c294 into tensorflow:master Jan 19, 2023
@chunnienc chunnienc deleted the bazel-cpp17 branch January 19, 2023 18:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants