-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
webgpu: Support AdapterInfo #6862
Changes from 4 commits
7539a76
41c3f5e
b4236cf
13bf178
e3a7d3d
42c1cc5
058f97f
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,30 @@ | ||
/** | ||
* @license | ||
* Copyright 2022 Google LLC. All Rights Reserved. | ||
* Licensed under the Apache License, Version 2.0 (the "License"); | ||
* you may not use this file except in compliance with the License. | ||
* You may obtain a copy of the License at | ||
* | ||
* http://www.apache.org/licenses/LICENSE-2.0 | ||
* | ||
* Unless required by applicable law or agreed to in writing, software | ||
* distributed under the License is distributed on an "AS IS" BASIS, | ||
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
* See the License for the specific language governing permissions and | ||
* limitations under the License. | ||
* ============================================================================= | ||
*/ | ||
|
||
export class AdapterInfo { | ||
private vendor: string; | ||
|
||
constructor(adapterInfo: GPUAdapterInfo) { | ||
if (adapterInfo) { | ||
this.vendor = adapterInfo.vendor; | ||
} | ||
} | ||
|
||
isIntel(): boolean { | ||
return this.vendor === 'intel'; | ||
} | ||
} |
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -50,7 +50,8 @@ if (isWebGPUSupported()) { | |
deviceDescriptor.requiredFeatures = ['timestamp-query']; | ||
} | ||
const device: GPUDevice = await adapter.requestDevice(deviceDescriptor); | ||
return new WebGPUBackend(device); | ||
const adapterInfo = await adapter.requestAdapterInfo(); | ||
return new WebGPUBackend(device, adapterInfo); | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Question: Can we only pass adapter to WebGPUBackend? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. We need to allow the user to specify the same device with tfjs to do interop. However, we can't do it if passing adapter to |
||
}, 3 /*priority*/); | ||
} | ||
|
||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
According to #6871 (review), please remove "All Rights Reserved." for the new files.