Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add kernel RaggedRange for CPU and WebGL backend #6871

Merged
merged 4 commits into from
Oct 10, 2022
Merged

Conversation

ahmedsabie
Copy link
Contributor

@ahmedsabie ahmedsabie commented Sep 28, 2022

To see the logs from the Cloud Build CI, please join either our discussion or announcement mailing list.


This change is Reviewable

Copy link
Member

@mattsoulanille mattsoulanille left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a quick review removing "all rights reserved" from the license headers of new files (don't change existing files).

tfjs-backend-cpu/src/kernels/RaggedRange.ts Outdated Show resolved Hide resolved
tfjs-backend-cpu/src/kernels/RaggedRange_impl.ts Outdated Show resolved Hide resolved
tfjs-backend-webgl/src/kernels/RaggedRange.ts Outdated Show resolved Hide resolved
tfjs-core/src/ops/ragged_range.ts Outdated Show resolved Hide resolved
tfjs-core/src/ops/ragged_range_test.ts Outdated Show resolved Hide resolved
Copy link
Collaborator

@lina128 lina128 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: :shipit: complete! 1 of 1 approvals obtained (waiting on @ahmedsabie and @pyu10055)


tfjs-backend-cpu/src/kernels/RaggedRange_impl.ts line 20 at r1 (raw file):

import {DataType, TypedArray, util} from '@tensorflow/tfjs-core';

const INT32_MAX = 2147483647;

Why not use Number.MAX_SAFE_INTEGER?

Code quote:

const INT32_MAX = 2147483647

This was referenced Sep 30, 2022
Copy link
Collaborator

@pyu10055 pyu10055 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you for adding this op.

Reviewed 12 of 12 files at r1, all commit messages.
Reviewable status: :shipit: complete! 2 of 1 approvals obtained (waiting on @ahmedsabie)

Copy link
Member

@mattsoulanille mattsoulanille left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@pyu10055 pyu10055 merged commit fd95c22 into master Oct 10, 2022
@pyu10055 pyu10055 deleted the ragged-range branch October 10, 2022 17:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants