-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add kernel RaggedRange for CPU and WebGL backend #6871
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a quick review removing "all rights reserved" from the license headers of new files (don't change existing files).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: complete! 1 of 1 approvals obtained (waiting on @ahmedsabie and @pyu10055)
tfjs-backend-cpu/src/kernels/RaggedRange_impl.ts
line 20 at r1 (raw file):
import {DataType, TypedArray, util} from '@tensorflow/tfjs-core'; const INT32_MAX = 2147483647;
Why not use Number.MAX_SAFE_INTEGER?
Code quote:
const INT32_MAX = 2147483647
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thank you for adding this op.
Reviewed 12 of 12 files at r1, all commit messages.
Reviewable status: complete! 2 of 1 approvals obtained (waiting on @ahmedsabie)
a515495
to
15d29d8
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
To see the logs from the Cloud Build CI, please join either our discussion or announcement mailing list.
This change is