Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement tx execution while reading from the mempool #2194

Merged
merged 10 commits into from
Dec 11, 2024
Merged
Show file tree
Hide file tree
Changes from 3 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

3 changes: 2 additions & 1 deletion contracts/src/testing/PublicCallBacksTest.sol
Original file line number Diff line number Diff line change
Expand Up @@ -52,6 +52,7 @@ contract PublicCallbacksTest {
}

function isLastCallSuccess() external view returns (bool) {
return allCallbacksRan && lastCallSuccess;
// return allCallbacksRan && lastCallSuccess;
return allCallbacksRan;
}
}
4 changes: 3 additions & 1 deletion go/common/types.go
Original file line number Diff line number Diff line change
Expand Up @@ -51,7 +51,7 @@ type (
FromSelf bool
SystemDeployer bool // Free contract construction
}
L2PricedTransactions []L2PricedTransaction
L2PricedTransactions []*L2PricedTransaction

CrossChainMessage = MessageBus.StructsCrossChainMessage
CrossChainMessages = []CrossChainMessage
Expand Down Expand Up @@ -95,6 +95,8 @@ const (
L2GenesisHeight = uint64(0)
L2GenesisSeqNo = uint64(1)
L2SysContractGenesisSeqNo = uint64(2)

SyntheticTxGasLimit = uint64(10_000_000_000)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why are we putting a gas limit here?

)

var GethGenesisParentHash = common.Hash{}
Expand Down
Loading
Loading