Implement tx execution while reading from the mempool #2194
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
go/common/types.go
Outdated
| @@ -95,6 +95,8 @@ const ( | |||
| L2GenesisHeight = uint64(0) | |||
| L2GenesisSeqNo = uint64(1) | |||
| L2SysContractGenesisSeqNo = uint64(2) | |||
|
|
|||
| SyntheticTxGasLimit = uint64(10_000_000_000) | |||
There was a problem hiding this comment.
Why are we putting a gas limit here?
| // Pop removes the best transaction, *not* replacing it with the next one from | ||
| // the same account. This should be used when a transaction cannot be executed | ||
| // and hence all subsequent ones should be discarded from the same account. | ||
| func (t *transactionsByPriceAndNonce) Pop() { |
There was a problem hiding this comment.
As this is copy paste, can we add additional functions with proper namings - PopToNextAccount or MoveAccount that call those; It's going to make our code that uses them clearer
There was a problem hiding this comment.
I'd rather keep it as it is, so we can easily keep it in sync
StefanIliev545
approved these changes
Dec 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why this change is needed
The "sequencer" functionality of building a new batch was implemented weirdly
Previously the validator and sequencer execution was identical, with the exception that the sequencer would read all transactions that fit in a batch from the mempool.
This could be used in DOS attacks.
What changes were made as part of this PR
PR checks pre-merging
Please indicate below by ticking the checkbox that you have read and performed the required
PR checks