Skip to content
This repository has been archived by the owner on Apr 3, 2024. It is now read-only.

upgrade temporal to v1.16.1 #64

Closed
wants to merge 4 commits into from

Conversation

balchua
Copy link
Contributor

@balchua balchua commented Apr 30, 2022

What changed?
Upgrade to temporal v1.16.1, recently released and ui-server to v0.13.0. This also fixes #46

Why?
To keep pace with temporal releases

How did you test it?
Tested locally, by creating workflows.

Potential risks
There is a breaking API reported in temporal. Refer to this

Is hotfix candidate?
No

server.go Outdated Show resolved Hide resolved
@jlegrone
Copy link
Collaborator

jlegrone commented May 5, 2022

@balchua
Copy link
Contributor Author

balchua commented May 5, 2022

Hey @balchua, do you mind updating https://github.com/DataDog/temporalite/blob/main/.github/workflows/release.yml and https://github.com/DataDog/temporalite/blob/main/.github/workflows/ci.yml to Go 1.18? I think that should fix the build.

Sure. I will bump up the ui-server dependency to the v0.12.2. I also tried to build it on windows and it builds successfully.

@codecov-commenter
Copy link

Codecov Report

Merging #64 (c87409d) into main (0797d11) will decrease coverage by 0.83%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main      #64      +/-   ##
==========================================
- Coverage   40.38%   39.55%   -0.84%     
==========================================
  Files          12       12              
  Lines         770      766       -4     
==========================================
- Hits          311      303       -8     
- Misses        437      441       +4     
  Partials       22       22              
Impacted Files Coverage Δ
server.go 52.00% <ø> (-7.50%) ⬇️

📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

@jlegrone
Copy link
Collaborator

jlegrone commented May 7, 2022

Thanks @balchua! I ended up needing to push a couple more changes to update docs and test for #46, so opened #66 based on your changes. Closing this PR now that #66 is merged.

@jlegrone jlegrone closed this May 7, 2022
@balchua balchua deleted the feature/upgrade-temporal branch May 7, 2022 22:14
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Does not build on Windows
4 participants