Skip to content
This repository has been archived by the owner on Apr 3, 2024. It is now read-only.

Does not build on Windows #46

Closed
cretz opened this issue Feb 24, 2022 · 3 comments · Fixed by #66
Closed

Does not build on Windows #46

cretz opened this issue Feb 24, 2022 · 3 comments · Fixed by #66
Labels
bug Something isn't working

Comments

@cretz
Copy link
Member

cretz commented Feb 24, 2022

Expected Behavior

Builds on Windows.

Actual Behavior

Not building. From a fresh recursive git clone, a go build ./cmd/temporalite gives:

C:\Users\user\go\pkg\mod\github.com\temporalio\[email protected]\server\server.go:47:113: pattern generated/ui/_app/assets/pages/namespaces/\[namespace\]/queues/\[queue\]/*: syntax error in pattern

Since the UI server was added, https://github.com/temporalio/ui-server/issues/104 is causing problems with Windows build. Supporting the UI as a build flag (or one prefixed with a bang for opt-out) per #33 could alleviate this temporarily. Also, I'd recommend adding Windows do the CI workflow.

This is on Go 1.17.7. I have not investigated the fix, this is just for tracking.

@feedmeapples
Copy link
Contributor

For visibility https://github.com/temporalio/ui-server/issues/104#issuecomment-1051416368

@jlegrone
Copy link
Collaborator

This is blocked on the upstream ui-server issue.

In the mean time, Windows users can work around this by building Temporalite with the headless tag enabled:

go install -tags headless github.com/DataDog/temporalite/cmd/temporalite@latest

#47 added build/test support for Windows and macOS in addition to linux, so we should discover more platform specific issues before merging pull requests in the future.

@jlegrone
Copy link
Collaborator

jlegrone commented May 7, 2022

This should be fixed as a result of the update to Go 1.18.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working
Projects
None yet
3 participants