Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(client)!: Return a friendly type from handle.describe() #532

Merged
merged 3 commits into from
Mar 12, 2022
Merged

feat(client)!: Return a friendly type from handle.describe() #532

merged 3 commits into from
Mar 12, 2022

Conversation

lorensr
Copy link
Contributor

@lorensr lorensr commented Mar 12, 2022 •
edited by bergundy
Loading

Closes #482

@lorensr lorensr added this to the 0.19.0 milestone Mar 12, 2022
bergundy
bergundy approved these changes Mar 12, 2022
View reviewed changes
Copy link
Member

@bergundy bergundy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pre-approving

packages/client/src/types.ts Outdated Show resolved Hide resolved
packages/client/src/types.ts Outdated Show resolved Hide resolved
packages/client/src/types.ts Outdated Show resolved Hide resolved
packages/client/src/types.ts Outdated Show resolved Hide resolved
@lorensr
Copy link
Contributor Author

lorensr commented Mar 12, 2022

handle.describe() returns:

image

@lorensr lorensr merged commit 95c5bd2 into main Mar 12, 2022
@lorensr lorensr deleted the wrap2 branch March 12, 2022 17:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bergundy bergundy bergundy approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.19.0
Development

Successfully merging this pull request may close these issues.

[Feature Request] Wrap WorkflowHandle.describe output in a JS friendly object
2 participants
@lorensr @bergundy