Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Feature Request] Wrap WorkflowHandle.describe output in a JS friendly object #482

Closed
swyxio opened this issue Feb 16, 2022 · 4 comments · Fixed by #532
Closed

[Feature Request] Wrap WorkflowHandle.describe output in a JS friendly object #482

swyxio opened this issue Feb 16, 2022 · 4 comments · Fixed by #532
Assignees
@lorensr
Labels
enhancement New feature or request

Comments

@swyxio
Copy link
Contributor

swyxio commented Feb 16, 2022 •
edited
Loading

Is your feature request related to a problem? Please describe.

image

image

image

protobufjs/protobuf.js#1258

Describe the solution you'd like

Additional context
@swyxio swyxio added the enhancement New feature or request label Feb 16, 2022
@swyxio swyxio changed the title [Feature Request] nicer toString on protobuf.js output [Feature Request] make date/time fields in the SDK actually return datetime, not protobuf.js output Feb 16, 2022
@lorensr
Copy link
Contributor

lorensr commented Feb 16, 2022

The toObject at bottom looks promising: protobufjs/protobuf.js#1258 (comment)

@bergundy
Copy link
Member

We're going to wrap the output of describe in a JS friendly object instead of returning the raw grpc response.

@bergundy bergundy changed the title [Feature Request] make date/time fields in the SDK actually return datetime, not protobuf.js output [Feature Request] Wrap WorkflowHandle.describe output in a JS friendly object Feb 16, 2022
@bergundy
Copy link
Member

We've recently done this in Java and Python.

@cretz
Copy link
Member

cretz commented Feb 16, 2022

Related: temporalio/features#17

@bergundy bergundy mentioned this issue Mar 12, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@lorensr lorensr

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(client)!: Return a friendly type from handle.describe() temporalio/sdk-typescript
4 participants
@bergundy @cretz @lorensr @swyxio