Respect configured existingSecret in schema setup/update jobs [Issue #261] #262
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
perplexa
changed the title
|
LGTM, thanks for the PR! |
underrun
approved these changes
Jan 26, 2022
|
Thanks for the bug fix! |
tylercunnion
added a commit
to LiveRamp/temporal-helm-charts
that referenced
this pull request
Jan 30, 2022
* Release v1.12.2 (temporalio#230) * Bump Web to v1.12.0 (temporalio#231) * Guard security context based on appVersion (temporalio#232) Older docker images have permission issues with directories and prevent the dynamic configuration generation from working. This change only runs the temporal server as a different user if the image can support it. * Fail Elasticsearch schema creation job if curl has failed (temporalio#233) * support additional stores (temporalio#234) * Release 1.13.0 (temporalio#237) * Bumpt Web to v1.13.0 (temporalio#238) * Add node selector tolerations affinity to jobs (temporalio#239) * add nodeSelector affinity and tolerations to jobs * add admintools nodeSelector tolerations and affinity * bump chart to 0.13.2 * fixed indentation issue * Release 1.13.1 (temporalio#240) * Release 1.14.0 (temporalio#250) * Fail elasticsearch index creation if template installation fails (temporalio#252) * Update Elasticsearch to 7.16.2 (temporalio#254) * allowed disable admintools (temporalio#256) * Support adding custom service account (temporalio#246) Fixes: issue temporalio#245 This patch: * Add option in values.yaml that enable optionaly creating custom service account, with following properties: * values.yaml has set with serviceAccount.create to false, so by default they use kubernetes default service account - this will make this change backward compatible * Once serviceAccount.create is marked to true, it use default name which is temporal.fullname, but can be customized with serviceAccount.name * Users can add extraAnnotations to add any additional annotations for service acccounts * Usually associating k8s service account with public cloud IAM role is done by adding custom annotation to serviceAccount, so this will enable users to pass such annotations to temporal serviceAccount * Created a custom serviceAccount with pre-install helm hook with low hook-weight as temporal server job is running with pre-install helm hook in some cases and serviceAccount should be created before job execution for the jobs run with custom serviceAccount * Fix wrong metricRelabeling key (temporalio#243) * Update README.md with notes on production usage (temporalio#255) * Add `quote` filter to Ingress TLS hosts (temporalio#241) This is useful when your TLS hosts values have wildcard asterisks so they aren't confused with YAML anchors. This should be an otherwise non-functional change. * Update metrics config to user server global config, not per-service. (temporalio#251) * Update missing references (temporalio#258) * Fix using existingSecret in jobs (temporalio#262) * fix schema-setup job init-containers (temporalio#265) * put or on one line (temporalio#266) for reasons Co-authored-by: Alex Shtin <[email protected]> Co-authored-by: Ruslan <[email protected]> Co-authored-by: Kris Rousey <[email protected]> Co-authored-by: Alfred Landrum <[email protected]> Co-authored-by: David Reiss <[email protected]> Co-authored-by: Blair MacNeil <[email protected]> Co-authored-by: David Reiss <[email protected]> Co-authored-by: Mikhail Gryzykhin <[email protected]> Co-authored-by: Roey Berman <[email protected]> Co-authored-by: Tihomir Surdilovic <[email protected]> Co-authored-by: 陈杨文 <[email protected]> Co-authored-by: Harish Kumar <[email protected]> Co-authored-by: Matthias Nguyen <[email protected]> Co-authored-by: swyx <[email protected]> Co-authored-by: Srikanth Chelluri <[email protected]> Co-authored-by: Daniel König <[email protected]> Co-authored-by: Derek Wilson <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was changed
This PR fixes the issue described in Issue #261.
Why?
It prevents setting up temporal with an existing existing secret to bootstrap a cassandra cluster's schemas.
Checklist
Closes [Bug] Setting existingSecret not respected by schema setup/update jobs #261
How was this tested: