forked from temporalio/helm-charts
-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fetch from upstream #1
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Older docker images have permission issues with directories and prevent the dynamic configuration generation from working. This change only runs the temporal server as a different user if the image can support it.
* add nodeSelector affinity and tolerations to jobs * add admintools nodeSelector tolerations and affinity * bump chart to 0.13.2 * fixed indentation issue
Fixes: issue #245 This patch: * Add option in values.yaml that enable optionaly creating custom service account, with following properties: * values.yaml has set with serviceAccount.create to false, so by default they use kubernetes default service account - this will make this change backward compatible * Once serviceAccount.create is marked to true, it use default name which is temporal.fullname, but can be customized with serviceAccount.name * Users can add extraAnnotations to add any additional annotations for service acccounts * Usually associating k8s service account with public cloud IAM role is done by adding custom annotation to serviceAccount, so this will enable users to pass such annotations to temporal serviceAccount * Created a custom serviceAccount with pre-install helm hook with low hook-weight as temporal server job is running with pre-install helm hook in some cases and serviceAccount should be created before job execution for the jobs run with custom serviceAccount
for reasons
k-smathers
approved these changes
Jan 30, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.