Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fetch from upstream #1

Merged
merged 22 commits into from
Jan 30, 2022
Merged

Fetch from upstream #1

merged 22 commits into from
Jan 30, 2022

Conversation

tylercunnion
Copy link

No description provided.

alexshtin and others added 22 commits October 4, 2021 13:05
Older docker images have permission issues with directories and prevent the
dynamic configuration generation from working. This change only runs the
temporal server as a different user if the image can support it.
* add nodeSelector affinity and tolerations to jobs

* add admintools nodeSelector tolerations and affinity

* bump chart to 0.13.2

* fixed indentation issue
Fixes: issue #245

This patch:
* Add option in values.yaml that enable optionaly creating custom
  service account, with following properties:
  * values.yaml has set with serviceAccount.create to false, so by
    default they use kubernetes default service account - this will
    make this change backward compatible
  * Once serviceAccount.create is marked to true, it use default name
    which is temporal.fullname, but can be customized with serviceAccount.name
  * Users can add extraAnnotations to add any additional annotations for
    service acccounts
    * Usually associating k8s service account with public cloud IAM role
      is done by adding custom annotation to serviceAccount, so this
      will enable users to pass such annotations to temporal
      serviceAccount
* Created a custom serviceAccount with pre-install helm hook with low
  hook-weight as temporal server job is running with pre-install
  helm hook in some cases and serviceAccount should be created before
  job execution for the jobs run with custom serviceAccount
This is useful when your TLS hosts values have wildcard asterisks so
they aren't confused with YAML anchors. This should be an otherwise
non-functional change.
@tylercunnion tylercunnion requested a review from a team as a code owner January 30, 2022 05:21
@tylercunnion tylercunnion merged commit 13deca0 into LiveRamp:liveramp Jan 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.