-
Notifications
You must be signed in to change notification settings - Fork 70
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove sass-build dependency #5245
Conversation
ffe9544
to
4633778
Compare
501b921
to
1f1f384
Compare
331655c
to
d335672
Compare
This is not part of this PR, but we should evaluate if we need the Edited |
a943e51
to
7afb9c7
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
In this PR:
sass-build
dependency along with related config files.embed-assets
andcreate-component
.core/_index.import.scss
tocore/index.scss
as we no longer need to cater tonode-sass
specific partials.core
package.Things to do:
Fix Fluent theme compilation warnings frompostcss-calc