Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove sass-build dependency #5245

Merged
merged 10 commits into from
Dec 5, 2024
Merged

Remove sass-build dependency #5245

merged 10 commits into from
Dec 5, 2024

Conversation

Juveniel
Copy link
Contributor

@Juveniel Juveniel commented Nov 28, 2024

In this PR:

  • Removed sass-build dependency along with related config files.
  • Removed unused gulp tasks embed-assets and create-component.
  • Renamed core/_index.import.scss to core/index.scss as we no longer need to cater to node-sass specific partials.
  • Fixed a issue with the compilation of the core package.

Things to do:

  • Fix Fluent theme compilation warnings from postcss-calc

@Juveniel Juveniel added the Infrastructure Issues related overall infrastructure for build, test and deployment label Nov 28, 2024
@Juveniel Juveniel self-assigned this Nov 28, 2024
@Juveniel Juveniel force-pushed the remove-sass-build-dep branch from ffe9544 to 4633778 Compare November 28, 2024 14:55
@Juveniel Juveniel marked this pull request as ready for review November 29, 2024 13:18
@Juveniel Juveniel requested a review from a team as a code owner November 29, 2024 13:18
@Juveniel Juveniel added this to the 2025 Q1 (Feb) milestone Nov 29, 2024
@Juveniel Juveniel changed the title Remove sass build dependency Remove sass-build dependency Nov 29, 2024
@epetrow epetrow force-pushed the remove-sass-build-dep branch from 501b921 to 1f1f384 Compare December 2, 2024 17:39
@zhpenkov zhpenkov self-requested a review December 3, 2024 14:20
@epetrow epetrow requested review from inikolova and TeyaVes December 4, 2024 12:33
@epetrow epetrow force-pushed the remove-sass-build-dep branch from 331655c to d335672 Compare December 5, 2024 08:46
@zhpenkov
Copy link
Contributor

zhpenkov commented Dec 5, 2024

This is not part of this PR, but we should evaluate if we need the sass:standalone build, as it compiles all components' index files, which do not compile to any component styles. Currently, the sass: standalone only tests whether the dependency files in the index are imported correctly. The sass script already covers that.

Edited
The sass:standalone script has been removed.

@epetrow epetrow force-pushed the remove-sass-build-dep branch from a943e51 to 7afb9c7 Compare December 5, 2024 13:37
@epetrow epetrow requested a review from zhpenkov December 5, 2024 13:42
Copy link
Contributor

@zhpenkov zhpenkov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@epetrow epetrow merged commit 2f037c6 into develop Dec 5, 2024
27 checks passed
@epetrow epetrow deleted the remove-sass-build-dep branch December 5, 2024 14:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Infrastructure Issues related overall infrastructure for build, test and deployment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants