Skip to content

Commit

Permalink
Merge branch 'develop' into remove-sass-build-dep
Browse files Browse the repository at this point in the history
  • Loading branch information
epetrow authored Dec 4, 2024
2 parents 1f1f384 + fdf723f commit 331655c
Show file tree
Hide file tree
Showing 20 changed files with 36 additions and 16 deletions.
2 changes: 1 addition & 1 deletion packages/bootstrap/scss/imageeditor/_variables.scss
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ $kendo-image-editor-content-border-width: 1px !default;

$kendo-image-editor-action-pane-padding-y: k-spacing(8) !default;
$kendo-image-editor-action-pane-padding-x: k-spacing(4) !default;
$kendo-image-editor-action-pane-width: if( $kendo-image-editor-content-border-width == null, 240px, calc( 240px + #{$kendo-image-editor-content-border-width} ) ) !default;
$kendo-image-editor-action-pane-width: if( $kendo-image-editor-content-border-width == null, 250px, calc( 250px + #{$kendo-image-editor-content-border-width} ) ) !default;

$kendo-image-editor-crop-border-width: 1px !default;
$kendo-image-editor-crop-border-style: dashed !default;
Expand Down
4 changes: 2 additions & 2 deletions packages/fluent/docs/customization-imageeditor.md
Original file line number Diff line number Diff line change
Expand Up @@ -230,8 +230,8 @@ The following table lists the available variables for customization.
<tr>
<td>$kendo-image-editor-action-pane-width</td>
<td>Number</td>
<td><code>if( $kendo-image-editor-content-border-width == 0, 240px, calc( 240px + #{$kendo-image-editor-content-border-width}) )</code></td>
<td><code>240px</code></td>
<td><code>if( $kendo-image-editor-content-border-width == 0, 270px, calc( 270px + #{$kendo-image-editor-content-border-width}) )</code></td>
<td><code>270px</code></td>
</tr>
<tr>
<td colspan="4" class="theme-variables-description-container"><div><b>Description</b><div class="theme-variables-description">Imageeditor action pane width.</div></div>
Expand Down
4 changes: 2 additions & 2 deletions packages/fluent/docs/customization.md
Original file line number Diff line number Diff line change
Expand Up @@ -15769,8 +15769,8 @@ The following table lists the available variables for customizing the Fluent the
<tr>
<td>$kendo-image-editor-action-pane-width</td>
<td>Number</td>
<td><code>if( $kendo-image-editor-content-border-width == 0, 240px, calc( 240px + #{$kendo-image-editor-content-border-width}) )</code></td>
<td><code>240px</code></td>
<td><code>if( $kendo-image-editor-content-border-width == 0, 270px, calc( 270px + #{$kendo-image-editor-content-border-width}) )</code></td>
<td><code>270px</code></td>
</tr>
<tr>
<td colspan="4" class="theme-variables-description-container"><div><b>Description</b><div class="theme-variables-description">Imageeditor action pane width.</div></div>
Expand Down
2 changes: 1 addition & 1 deletion packages/fluent/scss/imageeditor/_variables.scss
Original file line number Diff line number Diff line change
Expand Up @@ -67,7 +67,7 @@ $kendo-image-editor-action-pane-padding-y: k-spacing(3) !default;
$kendo-image-editor-action-pane-padding-x: k-spacing(3) !default;
/// Imageeditor action pane width.
/// @group imageeditor
$kendo-image-editor-action-pane-width: if( $kendo-image-editor-content-border-width == 0, 240px, calc( 240px + #{$kendo-image-editor-content-border-width}) ) !default;
$kendo-image-editor-action-pane-width: if( $kendo-image-editor-content-border-width == 0, 270px, calc( 270px + #{$kendo-image-editor-content-border-width}) ) !default;

/// Crop background color of the imageeditor.
/// @group imageeditor
Expand Down
8 changes: 4 additions & 4 deletions packages/html/src/action-sheet/action-sheet.spec.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -9,10 +9,10 @@ const states = [];
const options = {};

export type KendoActionSheetProps = {
children: React.JSX.Element | React.JSX.Element[],
children?: React.JSX.Element | React.JSX.Element[];
title?: string;
header?: typeof ActionSheetHeader;
footer?: string | typeof ActionSheetFooter;
header?: React.JSX.Element;
footer?: string | React.JSX.Element;
actions?: string[];
fullscreen?: boolean;
adaptive?: boolean;
Expand Down Expand Up @@ -68,7 +68,7 @@ export const ActionSheet = (
return true;
}
})
: children.type === ActionSheetItems
: children?.type === ActionSheetItems
? children
: <></>;

Expand Down
6 changes: 3 additions & 3 deletions packages/html/src/imageeditor/templates/imageeditor-crop.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -26,8 +26,8 @@ export const ImageEditorCrop = (props: any) => (
actionPane={
<FormNormal tag="div" className="k-imageeditor-pane-form" formButtons={
<>
<Button themeColor="primary">Confirm</Button>
<Button>Cancel</Button>
<Button themeColor="primary" icon="check">Confirm</Button>
<Button icon="cancel-outline">Cancel</Button>
</>
}>
<Fieldset layout="grid" legend="Crop Image" cols={2} gapX={2}>
Expand Down Expand Up @@ -56,7 +56,7 @@ export const ImageEditorCrop = (props: any) => (
label="Height:"
editor={ <NumericTextbox showClearButton={false} value="68" /> }
/>
<FormField
<FormField
colSpan="2"
editor={ <CheckboxWithLabelAfter>Lock aspect ratio</CheckboxWithLabelAfter> }
/>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -26,8 +26,8 @@ export const ImageEditorResize = (props: any) => (
actionPane={
<FormNormal tag="div" className="k-imageeditor-pane-form" formButtons={
<>
<Button themeColor="primary">Confirm</Button>
<Button>Cancel</Button>
<Button themeColor="primary" icon="check">Confirm</Button>
<Button icon="cancel-outline">Cancel</Button>
</>
}>
<Fieldset layout="grid" legend="Resize Image" cols={2} gapX={2}>
Expand Down
2 changes: 1 addition & 1 deletion packages/material/scss/imageeditor/_variables.scss
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ $kendo-image-editor-content-border-width: 1px !default;

$kendo-image-editor-action-pane-padding-y: k-spacing(8) !default;
$kendo-image-editor-action-pane-padding-x: k-spacing(4) !default;
$kendo-image-editor-action-pane-width: if( $kendo-image-editor-content-border-width == null, 240px, calc(240px + #{$kendo-image-editor-content-border-width}) ) !default;
$kendo-image-editor-action-pane-width: if( $kendo-image-editor-content-border-width == null, 280px, calc(280px + #{$kendo-image-editor-content-border-width}) ) !default;

$kendo-image-editor-crop-border-width: 1px !default;
$kendo-image-editor-crop-border-style: dashed !default;
Expand Down
Binary file modified tests/_output/bootstrap/imageeditor/imageeditor-crop-pane.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified tests/_output/bootstrap/imageeditor/imageeditor-resize-pane.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified tests/_output/classic/imageeditor/imageeditor-crop-pane.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified tests/_output/classic/imageeditor/imageeditor-resize-pane.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified tests/_output/default/imageeditor/imageeditor-crop-pane.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified tests/_output/default/imageeditor/imageeditor-resize-pane.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified tests/_output/fluent/imageeditor/imageeditor-crop-pane.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified tests/_output/fluent/imageeditor/imageeditor-resize-pane.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified tests/_output/material/imageeditor/imageeditor-crop-pane.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified tests/_output/material/imageeditor/imageeditor-resize-pane.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
10 changes: 10 additions & 0 deletions tests/imageeditor/imageeditor-crop-pane.html
Original file line number Diff line number Diff line change
Expand Up @@ -202,9 +202,19 @@ <h4>Image Editor Crop Pane</h4>
</fieldset>
<div class="k-form-buttons">
<button class="k-button k-button-md k-button-solid k-button-solid-primary k-rounded-md">
<span class="k-button-icon k-icon k-svg-icon k-svg-i-check">
<svg aria-hidden="true" focusable="false" xmlns="http://www.w3.org/2000/svg" viewBox="0 0 512 512">
<path d="M434.7 82.7 480 128 192 416 32 256l45.3-45.3L192 325.5z"></path>
</svg>
</span>
<span class="k-button-text">Confirm</span>
</button>
<button class="k-button k-button-md k-button-solid k-button-solid-base k-rounded-md">
<span class="k-button-icon k-icon k-svg-icon k-svg-i-cancel-outline">
<svg aria-hidden="true" focusable="false" xmlns="http://www.w3.org/2000/svg" viewBox="0 0 512 512">
<path d="M256 32c-56.1 0-107.4 20.6-146.7 54.7-8.1 7-15.6 14.6-22.6 22.6C52.6 148.6 32 199.9 32 256c0 123.7 100.3 224 224 224 56.1 0 107.4-20.6 146.7-54.7 8.1-7 15.6-14.6 22.6-22.6C459.4 363.4 480 312.1 480 256c0-123.7-100.3-224-224-224m0 416c-106 0-192-86-192-192 0-47.2 17.1-90.5 45.4-124L380 402.6c-33.5 28.3-76.8 45.4-124 45.4m146.6-68L132 109.4C165.5 81.1 208.8 64 256 64c106 0 192 86 192 192 0 47.2-17.1 90.5-45.4 124"></path>
</svg>
</span>
<span class="k-button-text">Cancel</span>
</button>
</div>
Expand Down
10 changes: 10 additions & 0 deletions tests/imageeditor/imageeditor-resize-pane.html
Original file line number Diff line number Diff line change
Expand Up @@ -194,9 +194,19 @@ <h4>Image Editor Resize Pane</h4>
</fieldset>
<div class="k-form-buttons">
<button class="k-button k-button-md k-button-solid k-button-solid-primary k-rounded-md">
<span class="k-button-icon k-icon k-svg-icon k-svg-i-check">
<svg aria-hidden="true" focusable="false" xmlns="http://www.w3.org/2000/svg" viewBox="0 0 512 512">
<path d="M434.7 82.7 480 128 192 416 32 256l45.3-45.3L192 325.5z"></path>
</svg>
</span>
<span class="k-button-text">Confirm</span>
</button>
<button class="k-button k-button-md k-button-solid k-button-solid-base k-rounded-md">
<span class="k-button-icon k-icon k-svg-icon k-svg-i-cancel-outline">
<svg aria-hidden="true" focusable="false" xmlns="http://www.w3.org/2000/svg" viewBox="0 0 512 512">
<path d="M256 32c-56.1 0-107.4 20.6-146.7 54.7-8.1 7-15.6 14.6-22.6 22.6C52.6 148.6 32 199.9 32 256c0 123.7 100.3 224 224 224 56.1 0 107.4-20.6 146.7-54.7 8.1-7 15.6-14.6 22.6-22.6C459.4 363.4 480 312.1 480 256c0-123.7-100.3-224-224-224m0 416c-106 0-192-86-192-192 0-47.2 17.1-90.5 45.4-124L380 402.6c-33.5 28.3-76.8 45.4-124 45.4m146.6-68L132 109.4C165.5 81.1 208.8 64 256 64c106 0 192 86 192 192 0 47.2-17.1 90.5-45.4 124"></path>
</svg>
</span>
<span class="k-button-text">Cancel</span>
</button>
</div>
Expand Down

0 comments on commit 331655c

Please sign in to comment.