Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Extract colorpicker variables into separate files #1891

Merged
merged 2 commits into from
Sep 18, 2020
Merged

Extract colorpicker variables into separate files #1891

merged 2 commits into from
Sep 18, 2020

Conversation

joneff
Copy link
Contributor

@joneff joneff commented Sep 17, 2020 •
edited
Loading

Part of #1872

Notable changes:

  • remove circular dependency between colorpicker and popup
  • introduce $popup-content-padding-* variables

@joneff joneff added Enhancement New feature of an existing functionality or an improvement of an existing functionality. C: ColorPicker labels Sep 17, 2020
@joneff joneff added this to the 2021.1 milestone Sep 17, 2020
@joneff joneff requested a review from a team September 17, 2020 09:53
@joneff joneff self-assigned this Sep 17, 2020
@joneff joneff mentioned this pull request Sep 17, 2020
Closed
78 tasks
@joneff
fix(colorpicker): extract colorpicker variables into separate files
3651e66 
* remove circular dependency between colorpicker and popup
@joneff joneff force-pushed the colorpicker-variables branch from 07758f1 to 3651e66 Compare September 17, 2020 12:46
@joneff joneff merged commit c0a39ca into develop Sep 18, 2020
@joneff joneff deleted the colorpicker-variables branch September 18, 2020 05:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PreslavKozovski PreslavKozovski PreslavKozovski approved these changes

Assignees

@joneff joneff

Labels
C: ColorPicker Enhancement New feature of an existing functionality or an improvement of an existing functionality.
Projects
None yet
Milestone
2021.1
Development

Successfully merging this pull request may close these issues.
2 participants
@joneff @PreslavKozovski