Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extract component variables to their modiles #1872

Closed
78 tasks done
joneff opened this issue Sep 15, 2020 · 1 comment
Closed
78 tasks done

Extract component variables to their modiles #1872

joneff opened this issue Sep 15, 2020 · 1 comment
Labels
Epic A non-trivial issue that resolves large-scale problems
Milestone

Comments

@joneff
Copy link
Contributor

joneff commented Sep 15, 2020

Extract component variables to their modules i.e. for the component autocomplete the folder structure should be:

autocomplete/_variables.scss
autocomplete/_index.scss // <= this will be renamed to index.scss at some point
autocomplete/_layout.scss
autocomplete/_theme.scss

Inside index.scss

@import "../_variables.scss"; // <= this will be removed at some point
@import "../mixins/_index.scss"; // <= this will be removed at some point


// Dependencies
@import "../common/_index.scss"; // <= this will be removed at some point
@import "../input/_variables.scss"; // <= or if the component depends entirely, index.scss
@import "../popup/_index.scss"; // <= like so
@import "../icons/_index.scss"; // <= like so


// Component
@import "_variables.scss";
@import "_layout.scss";
@import "_theme.scss";

/cc @telerik/kendo-front-end

@joneff joneff added Enhancement New feature of an existing functionality or an improvement of an existing functionality. Epic A non-trivial issue that resolves large-scale problems labels Sep 15, 2020
@joneff joneff added this to the 2021.1 milestone Sep 15, 2020
This was referenced Sep 16, 2020
@joneff
Copy link
Contributor Author

joneff commented Oct 1, 2020

with #1936 this part is done! ... well mostly. there are a couple of cases where we narrowly avoid circular references or we use variables in a way we shouldn't. But for the most part this part of v5 transition is done!

@joneff joneff closed this as completed Oct 1, 2020
@joneff joneff removed the Enhancement New feature of an existing functionality or an improvement of an existing functionality. label Dec 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Epic A non-trivial issue that resolves large-scale problems
Projects
None yet
Development

No branches or pull requests

1 participant