Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Extract chat variables into separate files #1888

Merged
merged 1 commit into from
Sep 17, 2020
Merged

Extract chat variables into separate files #1888

merged 1 commit into from
Sep 17, 2020

Conversation

joneff
Copy link
Contributor

@joneff joneff commented Sep 17, 2020

Part of #1872

Notable changes:

  • remove circular dependency between chat and cards
  • scope card-deck styles specific to chat

@joneff
fix(chat): extract chat variables into separate files
2f23978 
* remove circular dependency between chat and cards
* scope card-deck styles specifc to chat
@joneff joneff added Enhancement New feature of an existing functionality or an improvement of an existing functionality. C:Chat labels Sep 17, 2020
@joneff joneff added this to the 2021.1 milestone Sep 17, 2020
@joneff joneff requested a review from a team September 17, 2020 09:05
@joneff joneff self-assigned this Sep 17, 2020
@joneff joneff mentioned this pull request Sep 17, 2020
Closed
78 tasks
@joneff joneff merged commit 8d7f3e8 into develop Sep 17, 2020
@joneff joneff deleted the chat-variables branch September 17, 2020 11:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PreslavKozovski PreslavKozovski PreslavKozovski approved these changes

Assignees

@joneff joneff

Labels
C:Chat Enhancement New feature of an existing functionality or an improvement of an existing functionality.
Projects
None yet
Milestone
2021.1
Development

Successfully merging this pull request may close these issues.
2 participants
@joneff @PreslavKozovski