Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: adding closeButtonLabel and -Title to notifications #1694

Merged
merged 2 commits into from
Apr 4, 2023
Merged

feat: adding closeButtonLabel and -Title to notifications #1694

merged 2 commits into from
Apr 4, 2023

Conversation

marvinLaubenstein
Copy link
Collaborator

Fix: #1667

@netlify
Copy link

netlify bot commented Mar 28, 2023 •
edited
Loading

✅ Deploy Preview for marvelous-moxie-a6e2fe ready!

Name Link
🔨 Latest commit 4d63435
🔍 Latest deploy log https://app.netlify.com/sites/marvelous-moxie-a6e2fe/deploys/642b178d307ebc0008a2a61e
😎 Deploy Preview https://deploy-preview-1694--marvelous-moxie-a6e2fe.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@marvinLaubenstein marvinLaubenstein requested review from acstll and felix-ico and removed request for acstll and nowseemee March 28, 2023 18:39
felix-ico
felix-ico approved these changes Mar 31, 2023
View reviewed changes
Copy link
Collaborator

@felix-ico felix-ico left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM  👍

felix-ico
felix-ico requested changes Mar 31, 2023
View reviewed changes
Copy link
Collaborator

@felix-ico felix-ico left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey sorry, just had another look. I think we need to add the new props to storybook as well otherwise nobody else will know about this feature

@marvinLaubenstein marvinLaubenstein merged commit 021c9c9 into main Apr 4, 2023
@marvinLaubenstein marvinLaubenstein deleted the feat/notification-close-label-title-1667 branch April 4, 2023 12:44
acstll pushed a commit that referenced this pull request May 23, 2023
fix(notification): placement of closeButtonLabel and closeButtonTitle…
789b789 
… (see #1694)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@acstll acstll Awaiting requested review from acstll

@felix-ico felix-ico Awaiting requested review from felix-ico

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Notification Toast: Attribute to customize ARIA label of close button
2 participants
@marvinLaubenstein @felix-ico