Skip to content

Commit

Permalink
fix(notification): placement of closeButtonLabel and closeButtonTitle…
Browse files Browse the repository at this point in the history
… (see #1694)
  • Loading branch information
Arturo committed May 23, 2023
1 parent d17e66c commit 789b789
Show file tree
Hide file tree
Showing 2 changed files with 7 additions and 4 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -117,7 +117,7 @@
[part~='base'] {
border: 1px solid white;
}

[part='close-button'] {
--color-ghost: white;
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -141,11 +141,14 @@ export class Notification {
part="close-button"
variant="ghost"
onClick={this.close}
aria-label={this.closeButtonLabel}
title={this.closeButtonTitle}
>
<slot name="close-icon">
<scale-icon-action-circle-close size={ICON_SIZE} decorative />
<scale-icon-action-circle-close
aria-label={this.closeButtonLabel}
accessibilityTitle={this.closeButtonTitle}
decorative
size={ICON_SIZE}
/>
</slot>
</scale-button>
)}
Expand Down

0 comments on commit 789b789

Please sign in to comment.