Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Notification Toast: Attribute to customize ARIA label of close button #1667

Closed
georgwittberger-telekom-mms opened this issue Mar 17, 2023 · 1 comment · Fixed by #1694
Closed
Assignees
Labels
feature New component features and enhancements

Comments

@georgwittberger-telekom-mms
Copy link

georgwittberger-telekom-mms commented Mar 17, 2023

Description

The current implementation of the Notification Toast component sets the fixed ARIA label "close" for the close button. For better i18n support it would be useful if we could pass a custom label text via attribute, e.g. closeButtonLabel

Use Case

Applications with support for multiple languages should be able to define a localized text for the ARIA label of the close button.

@georgwittberger-telekom-mms georgwittberger-telekom-mms added the feature New component features and enhancements label Mar 17, 2023
@marvinLaubenstein marvinLaubenstein self-assigned this Mar 20, 2023
@marvinLaubenstein
Copy link
Collaborator

Hi @georgwittberger-t-systems-mms, you're definitely right about that. This is a very good improvement in accessibility. I will take care of it in a timely manner, thank you

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New component features and enhancements
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants