Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add "Authorization" in the list of Cors allowed headers (#4249) #4251

Merged
merged 1 commit into from
Dec 19, 2022

Conversation

chicco785
Copy link
Contributor

@chicco785 chicco785 commented Dec 18, 2022

Issue #4249

@chicco785
Copy link
Contributor Author

@fgalan looking at the code I realize you are propagating the X-AUTH-TOKEN header. Which I believe is an interesting functionality also for the OAuth tokens using the standard header. So, instead of duplicating the code to reproduce the functionality, the smartest way could be to set the name of this header via an environment variable, so that the same functionality can be shared without duplications. But I have no clue how to do that :)

Update CHANGES_NEXT_RELEASE

Update cors related documentation
@fgalan
Copy link
Member

fgalan commented Dec 19, 2022

@fgalan looking at the code I realize you are propagating the X-AUTH-TOKEN header. Which I believe is an interesting functionality also for the OAuth tokens using the standard header. So, instead of duplicating the code to reproduce the functionality, the smartest way could be to set the name of this header via an environment variable, so that the same functionality can be shared without duplications. But I have no clue how to do that :)

Unsure... but let's move it out of this PR into an independent issue so we can discuss there.

Could you create the issue, please? Thanks!

Copy link
Member

@fgalan fgalan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fgalan fgalan merged commit f0ee2ed into telefonicaid:master Dec 19, 2022
@fgalan
Copy link
Member

fgalan commented Dec 19, 2022

@fisuda this PR does modifications to some .md files. Not sure if they have equivalence in Japanese translation, in that case it would be great if you could sync the changes, please.

Thanks!

@fisuda
Copy link
Contributor

fisuda commented Dec 20, 2022

I send the PR #4253. Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants