-
Notifications
You must be signed in to change notification settings - Fork 265
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cors allowed headers do not include "Authorization" which is the default headers used with OAuth. #4249
Comments
If you create the pull request for adding it, we can include it in the next release (soon to be frozen ;) Is this the only point that need to be touched? Please check also documentation. Finally, don't forget to add the corresponding entry to CHANGES_NEXT_RELEASE file, please. Thanks! |
Btw, could you provide a little more context about the usage? I mean, in which case (architecture, etc.) are you using Orion with a system requiring CORS. Thanks again! |
Not a C developer. Said that, if it's just about adding that to the list, I can do, more complex if I need to develop a test case :) |
We have an admin interface, now in front of Orion, we recently added a new authz proxy based on envoy, which by default pass all headers, so the issue popped up. |
Do a PR without the test so we can check if something break ;) Next, maybe just adapting (copy-paste-modify) some of the tests in https://github.com/telefonicaid/fiware-orion/tree/master/test/functionalTest/cases/0501_cors would suffice. Please have a look. |
Add "Authorization" in the list of Cors allowed headers (#4249)
Fixed by PR #4251 |
(JP) ADD doc about "Authorization" in the list of Cors allowed headers (#4249)
Could you please add "Authorization" in the list of Cors allowed headers?
fiware-orion/src/lib/rest/HttpHeaders.h
Line 68 in 0dc7718
The text was updated successfully, but these errors were encountered: