ADD subscription expression evaluation #1687
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| * I don't like too much to have a function with two quite parallel behaviours in the same logic. Probably a | ||
| * smarter design will be to divide this function in two part: the one focused in string parsing and the one | ||
| * focused in appliying filters to each different sytem (either in memory or as BSON). | ||
| * |
There was a problem hiding this comment.
Opinions on the above comment and ideas to improve the current implementation are welcome :)
There was a problem hiding this comment.
Well, you have already split the function in two. Very little common code, just go all the way (which means we'll have some code duplicated). I don't see any problem with that.
I also don't see any problem in keeping it the way it is now. A 'fork function'.
What is not very nice is the 'two out of three parameters', that's all.
| # 06. Dump accumulator (2 notifications) | ||
| # | ||
|
|
||
| echo "01. Create subscription with q: colour!=black,white" |
| @@ -112,6 +112,25 @@ std::string ContextElement::render(ConnectionInfo* ciP, RequestType requestType, | |||
|
|
|||
| /* **************************************************************************** | |||
| * | |||
| * ContextElement::getAttribute | |||
| */ | |||
| ContextAttribute* ContextElement::getAttribute(std::string attrName) | |||
There was a problem hiding this comment.
Would probably have been better to implement a 'lookup' method for ContextAttributeVector, but, never mind.
NTC
|
LGTM |
1 similar comment
|
LGTM |
kzangeli
pushed a commit
that referenced
this pull request
Jan 19, 2016
…_filters_ngsiv2 ADD subscription expression evaluation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements part of #1316
@kzangeli
@crbrox