Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

POST /v2/entities behaves as options=keyValues when this parameter is not set #1688

Closed
fgalan opened this issue Jan 19, 2016 · 3 comments
Closed
Assignees
Milestone

Comments

@fgalan
Copy link
Member

fgalan commented Jan 19, 2016

Raised at #1687 (comment). Probably this is something that we missed before closing #1259.

In particular, the following changes should be done:

  • Right attribute value check for isObject in this case, e.g. if (! object) error()
  • Change the attribute "filling" logic to remove the heuristic in old versions (i.e. the one that look for "value" and if it doesn't find it, assumes that the value of the JSON property is the value of the attribute). The "filling" logic should be as dummy as the current way of working is, to avoid "hiding" bugs like in this case.

Not sure if this could affect other operations apart from POST /v2/entities. I rely on the exhaustive acceptance test done by @iariasleon in order to raise new cases ;)

@fgalan
Copy link
Member Author

fgalan commented Jan 19, 2016

Maybe a bit side-topic, but as part of this issue, the /test/functionalTest/cases/0999_update_single_attr_value_by_eid/update_single_attr_value_by_eid_error_handling.test.DISABLED should be fixed.

@fgalan
Copy link
Member Author

fgalan commented Jan 21, 2016

Fixed in PR #1701, but update_single_attr_value_by_eid_error_handling.test.DISABLED fixing pending.

@fgalan fgalan self-assigned this Jan 22, 2016
@fgalan
Copy link
Member Author

fgalan commented Jan 22, 2016

The sub-task related with the DISABLED test has been completed in PR #1709. Closing issue.

@fgalan fgalan closed this as completed Jan 22, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant