Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The knative/pkg import path changed to "knative.dev/pkg" #59

Merged
merged 1 commit into from
Aug 6, 2019
Merged

The knative/pkg import path changed to "knative.dev/pkg" #59

merged 1 commit into from
Aug 6, 2019

Conversation

vincent-pli
Copy link
Member

Follow the tektoncd/pipeline#1117

  • change the dependency path
  • update the import path

Changes

Submitter Checklist

These are the criteria that every PR should meet, please check them off as you
review them:

See the contribution guide for more details.

@tekton-robot tekton-robot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Aug 2, 2019
@vincent-pli
The knative/pkg import path changed to "knative.dev/pkg"
d8b8971 
folow the tektoncd/pipeline#1117
- change the dependency path
- update the import path
@vtereso
Copy link

vtereso commented Aug 5, 2019

Thanks @vincent-pli. I see some files like vendor/go.opencensus.io/metric/metricexport/reader.go where it's not just the pathing change. It looks like there have been some generator comments and other small differences as well?

@vincent-pli
Copy link
Member Author

@vtereso
Yes, since we turn to a certain revision of knative.dev/pkg, need resolve its dependencies and type definition also depends pkg so the code is re-generated.

@ncskier
Copy link
Member

ncskier commented Aug 6, 2019

Thanks @vincent-pli!
/approve
/lgtm

@tekton-robot tekton-robot added the lgtm Indicates that a PR is ready to be merged. label Aug 6, 2019
@tekton-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ncskier, vincent-pli

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tekton-robot tekton-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 6, 2019
@tekton-robot tekton-robot merged commit 98fd16a into tektoncd:master Aug 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bobcatfish bobcatfish Awaiting requested review from bobcatfish

@dlorenc dlorenc Awaiting requested review from dlorenc

Assignees

@ncskier ncskier

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@vincent-pli @vtereso @ncskier @tekton-robot