Bump github.com/knative/pkg dependency and deps… #1117
Conversation
googlebot
added
the
cla: yes
tekton-robot
added
the
approved
tekton-robot
added
the
size/XXL
vdemeester
force-pushed
the
bump-pkg
branch
2 times, most recently
from
e8f5654
to
b7fb048
Compare
|
Bumped kubernetes to 1.12.9 too |
|
The following is the coverage report on pkg/.
|
|
The following is the coverage report on pkg/.
|
|
The following is the coverage report on pkg/.
|
|
This looks pretty straight forward - thanks for doing it! /lgtm |
|
( @afrittoli i think /lgtm has to be on its own line! and also recently it looked like if there was any text following it, e.g. "/lgtm i love cats" it wouldnt work either XD) /lgtm |
|
ruh roh |
|
The following is the coverage report on pkg/.
|
|
The following is the coverage report on pkg/.
|
|
Thanks a bunch!!! |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: afrittoli, vdemeester The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
… and update import path as it is now `knative.dev/pkg` (as all knative projects) Signed-off-by: Vincent Demeester <[email protected]>
To follow what `knative.dev/*` have Signed-off-by: Vincent Demeester <[email protected]>
Signed-off-by: Vincent Demeester <[email protected]>
|
/lgtm |
folow the tektoncd/pipeline#1117 - change the dependency path - update the import path
folow the tektoncd/pipeline#1117 - change the dependency path - update the import path
folow the tektoncd/pipeline#1117 - change the dependency path - update the import path
folow the tektoncd/pipeline#1117 - change the dependency path - update the import path
Changes
… and update import path as it is now
knative.dev/pkg(as allknative projects)
It has to be done at some point 👼 I'll follow-up with PR in the other tekton repositories 👼
Signed-off-by: Vincent Demeester [email protected]
Submitter Checklist
These are the criteria that every PR should meet, please check them off as you
review them:
See the contribution guide for more details.
Double check this list of stuff that's easy to miss:
cmddir, please updatethe release Task and TaskRun to build and release this image