Add a specific verion for the image gcr.io/kaniko-project/executor #878
Conversation
googlebot
added
the
cla: yes
tekton-robot
added
size/S
|
/assign @vdemeester |
|
/ok-to-test |
tekton-robot
removed
the
needs-ok-to-test
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: houshengbo, vdemeester The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
tekton-robot
added
the
approved
|
@houshengbo can you rebase against master ? |
|
@vdemeester I have already done it. Thanks. |
docs/taskruns.md
Outdated
| image: gcr.io/kaniko-project/executor | ||
| # specifying DOCKER_CONFIG is required to allow kaniko to detect docker credential | ||
| env: | ||
| - name: "DOCKER_CONFIG" | ||
| value: "/builder/home/.docker/" | ||
| ======= | ||
| image: gcr.io/kaniko-project/executor:v0.9.0 | ||
| >>>>>>> 85e787e8... Add a specific verion for the image gcr.io/kaniko-project/executor |
There was a problem hiding this comment.
i think something went wrong with the merge conflict resolution here @houshengbo ! I think what you need to do is update line 337 with v0.9.0, remove <<<<<<< HEAD and remove everything from ======= to >>>>>>> 85e787e8... Add a specific verion for the image gcr.io/kaniko-project/executor
There was a problem hiding this comment.
oh sorry. forgot to resolve it.
|
Thanks @houshengbo ! /lgtm |
|
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Changes
Submitter Checklist
These are the criteria that every PR should meet, please check them off as you
review them:
See the contribution guide
for more details.
Release Notes