Add a specific version and context support for kaniko #32
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tekton-robot
added
size/XS
|
The similar PR is submitted to Tektoncd pipeline as well: tektoncd/pipeline#878 for version change. |
|
/assign @vdemeester |
houshengbo
force-pushed
the
add-specific-version
branch
from
68c41f0
to
bf1beb0
Compare
houshengbo
changed the title
houshengbo
force-pushed
the
add-specific-version
branch
2 times, most recently
from
ad0c68c
to
43c65c2
Compare
We need to pin to specific version rather than go with the dynamic latest commit. The version v0.9.0 seems to be a stable one. Add the parameter context support for kaniko.
houshengbo
force-pushed
the
add-specific-version
branch
from
43c65c2
to
1d8143e
Compare
tekton-robot
added
size/S
This was referenced May 23, 2019
|
/ok-to-test |
tekton-robot
removed
the
needs-ok-to-test
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: houshengbo, ImJasonH, vdemeester The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
tekton-robot
added
the
approved
This was referenced May 29, 2019
bobcatfish
reviewed
Jul 8, 2019
| @@ -30,4 +32,5 @@ spec: | |||
| command: | |||
| - /kaniko/executor | |||
| - --dockerfile=${inputs.params.DOCKERFILE} | |||
| - --context=/workspace/source/${inputs.params.CONTEXT} # The user does not need to care the workspace and the source. | |||
There was a problem hiding this comment.
nice!! :D p.s. with path templating (i.e. in this case ${inputs.resouces.source.path}/${inputs.params.CONTEXT}) the author of the Task wouldnt have to worry about it either :D
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We need to pin to specific version rather than go with the dynamic latest commit. The version v0.9.0 seems to be a stable one.
Add the parameter context support for kaniko.
Changes
Submitter Checklist
These are the criteria that every PR should meet, please check them off as you
review them:
See the contribution guide
for more details.