Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TEP074] Remove git-ssh Examples #6239

Merged
merged 1 commit into from
Feb 27, 2023

Conversation

JeromeJu
Copy link
Member

@JeromeJu JeromeJu commented Feb 27, 2023

Changes

This commit removes the git-ssh examples, which are flakey in CI while these are going to be removed along with the
git resources removal in the upcoming release.
And #6240 was opened to track for the replacement of the git credential usage.

fixes: #6228
/kind misc

Submitter Checklist

As the author of this PR, please check off the items in this checklist:

  • Has Docs included if any changes are user facing
  • Has Tests included if any functionality added or changed
  • Follows the commit message standard
  • Meets the Tekton contributor standards (including
    functionality, content, code)
  • Has a kind label. You can add one by adding a comment on this PR that contains /kind <type>. Valid types are bug, cleanup, design, documentation, feature, flake, misc, question, tep
  • [n/a] Release notes block below has been updated with any user facing changes (API changes, bug fixes, changes requiring upgrade notices or deprecation warnings)
  • [n/a] Release notes contains the string "action required" if the change requires additional action from users switching to the new release

Release Notes

NONE

@tekton-robot tekton-robot added release-note-none Denotes a PR that doesnt merit a release note. kind/misc Categorizes issue or PR as a miscellaneuous one. labels Feb 27, 2023
@tekton-robot tekton-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Feb 27, 2023
@pritidesai
Copy link
Member

It could be possible the keys might have expired on 02/24 🤔 I am on board to drop these two tests which started causing outages in our CI and given that the git resources are going away but at the same time, @JeromeJu please create an issue to re-introduce such examples (if they don't exists already) either using git resolver or git clone task.

/approve

@tekton-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: pritidesai

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tekton-robot tekton-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 27, 2023
@JeromeJu
Copy link
Member Author

JeromeJu commented Feb 27, 2023

It could be possible the keys might have expired on 02/24 🤔 I am on board to drop these two tests which started causing outages in our CI and given that the git resources are going away but at the same time, @JeromeJu please create an issue to re-introduce such examples (if they don't exists already) either using git resolver or git clone task.

/approve

Thanks @pritidesai #6240 is opened to track the replacement of such git-ssh example usage.

@Yongxuanzhang
Copy link
Member

/lgtm

Thanks!

@tekton-robot tekton-robot added the lgtm Indicates that a PR is ready to be merged. label Feb 27, 2023
@tekton-robot tekton-robot merged commit 7b52214 into tektoncd:main Feb 27, 2023
@pritidesai
Copy link
Member

pritidesai commented Feb 28, 2023

This fixes main but the branches CI are still broken with this failure 😭 We should cherry this into the branches 0.41 through 0.45:

/cherry-pick release-v0.41.x
/cherry-pick release-v0.42.x
/cherry-pick release-v0.43.x
/cherry-pick release-v0.44.x
/cherry-pick release-v0.45.x

@tekton-robot
Copy link
Collaborator

@pritidesai: cannot checkout releasev0.41.x: error checking out releasev0.41.x: exit status 1. output: error: pathspec 'releasev0.41.x' did not match any file(s) known to git

In response to this:

This fixes main but the branches CI are still broken with this failure 😭 We should cherry this into the branches 0.41 through 0.45:

/cherry-pick releasev0.41.x
/cherry-pick releasev0.42.x
/cherry-pick releasev0.43.x
/cherry-pick releasev0.44.x
/cherry-pick releasev0.45.x

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@pritidesai
Copy link
Member

I am sorry tekton-robot, I misspelled branch name 😞 Please try again:

/cherry-pick release-v0.41.x
/cherry-pick release-v0.42.x
/cherry-pick release-v0.43.x
/cherry-pick release-v0.44.x
/cherry-pick release-v0.45.x

@tekton-robot
Copy link
Collaborator

@pritidesai: new pull request created: #6241

In response to this:

I am sorry tekton-robot, I misspelled branch name 😞 Please try again:

/cherry-pick release-v0.41.x
/cherry-pick release-v0.42.x
/cherry-pick release-v0.43.x
/cherry-pick release-v0.44.x
/cherry-pick release-v0.45.x

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@pritidesai pritidesai added the needs-cherry-pick Indicates a PR needs to be cherry-pick to a release branch label Feb 28, 2023
@pritidesai
Copy link
Member

Let's try cherry picking one branch at a time:

/cherry-pick release-v0.42.x

@tekton-robot
Copy link
Collaborator

@pritidesai: new pull request created: #6242

In response to this:

Let's try cherry picking one branch at a time:

/cherry-pick release-v0.42.x

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@pritidesai
Copy link
Member

pritidesai commented Feb 28, 2023

/cherry-pick release-v0.43.x

@pritidesai
Copy link
Member

/cherry-pick release-v0.44.x

@tekton-robot
Copy link
Collaborator

@pritidesai: new pull request could not be created: failed to create pull request against tektoncd/pipeline#release-v0.42.x from head tekton-robot:cherry-pick-6239-to-release-v0.42.x: status code 422 not one of [201], body: {"message":"Validation Failed","errors":[{"resource":"PullRequest","code":"custom","message":"A pull request already exists for tekton-robot:cherry-pick-6239-to-release-v0.42.x."}],"documentation_url":"https://docs.github.com/rest/reference/pulls#create-a-pull-request"}

In response to this:

/cherry-pick release-v0.42.x

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@tekton-robot
Copy link
Collaborator

@pritidesai: new pull request created: #6243

In response to this:

/cherry-pick release-v0.44.x

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@pritidesai
Copy link
Member

/cherry-pick release-v0.43.x

@tekton-robot
Copy link
Collaborator

@pritidesai: new pull request created: #6244

In response to this:

/cherry-pick release-v0.43.x

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@pritidesai
Copy link
Member

/cherry-pick release-v0.45.x

@tekton-robot
Copy link
Collaborator

@pritidesai: new pull request created: #6245

In response to this:

/cherry-pick release-v0.45.x

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/misc Categorizes issue or PR as a miscellaneuous one. lgtm Indicates that a PR is ready to be merged. needs-cherry-pick Indicates a PR needs to be cherry-pick to a release branch release-note-none Denotes a PR that doesnt merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Potential flakes in our CI 🤔
4 participants