Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[TEP074] Remove Cluster pipelineResources #5996

Merged
merged 1 commit into from
Jan 19, 2023
Merged

[TEP074] Remove Cluster pipelineResources #5996

merged 1 commit into from
Jan 19, 2023

Conversation

JeromeJu
Copy link
Member

@JeromeJu JeromeJu commented Jan 16, 2023 •
edited
Loading

Changes

This commit removes the Cluster Resources support.
Removal of pipelineResources is broken up into removal of each resources packages.
This PR removes github.com/tektoncd/pipeline/pkg/apis/resource/v1alpha1/cluster,
the kubeconfigwriter image and the respective resources documentations.

Part of #5967
/kind misc

Submitter Checklist

As the author of this PR, please check off the items in this checklist:

  • Has Docs included if any changes are user facing
  • Has Tests included if any functionality added or changed
  • Follows the commit message standard
  • Meets the Tekton contributor standards (including
    functionality, content, code)
  • Has a kind label. You can add one by adding a comment on this PR that contains /kind <type>. Valid types are bug, cleanup, design, documentation, feature, flake, misc, question, tep
  • Release notes block below has been updated with any user facing changes (API changes, bug fixes, changes requiring upgrade notices or deprecation warnings)
  • Release notes contains the string "action required" if the change requires additional action from users switching to the new release

Release Notes

action required: please migrate off of `cluster` `pipelineresources` as it is removed, please refer to the doc at https://github.com/tektoncd/pipeline/blob/main/docs/pipelineresources.md#replacing-a-cluster-resource
`kubeconfigwriter` image are not built nor maintained from now on

@tekton-robot tekton-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Jan 16, 2023
@tekton-robot tekton-robot added the kind/misc Categorizes issue or PR as a miscellaneuous one. label Jan 16, 2023
@JeromeJu JeromeJu force-pushed the rm-cluster-resources branch from 17a5d41 to 633213e Compare January 16, 2023 23:05
@tekton-robot
Copy link
Collaborator

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/apis/resource/v1alpha1/pipelineresource_validation.go 88.9% 78.9% -9.9

@tekton-robot
Copy link
Collaborator

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage-df to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/apis/resource/v1alpha1/pipelineresource_validation.go 88.9% 78.9% -9.9

@JeromeJu JeromeJu force-pushed the rm-cluster-resources branch from 633213e to 04a07b2 Compare January 16, 2023 23:36
@tekton-robot
Copy link
Collaborator

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/apis/resource/v1alpha1/pipelineresource_validation.go 88.9% 93.8% 4.9

@tekton-robot
Copy link
Collaborator

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage-df to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/apis/resource/v1alpha1/pipelineresource_validation.go 88.9% 93.8% 4.9

@tekton-robot
Copy link
Collaborator

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/apis/resource/v1alpha1/pipelineresource_validation.go 88.9% 93.8% 4.9

@tekton-robot
Copy link
Collaborator

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage-df to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/apis/resource/v1alpha1/pipelineresource_validation.go 88.9% 93.8% 4.9

@JeromeJu JeromeJu mentioned this pull request Jan 17, 2023
Closed
12 tasks
@JeromeJu JeromeJu changed the title Remove Cluster pipelineResources [TEP0074] Remove Cluster pipelineResources Jan 17, 2023
@JeromeJu JeromeJu changed the title [TEP0074] Remove Cluster pipelineResources [TEP074] Remove Cluster pipelineResources Jan 17, 2023
@tekton-robot tekton-robot added release-note-action-required Denotes a PR that introduces potentially breaking changes that require user action. and removed release-note Denotes a PR that will be considered when it comes time to generate release notes. labels Jan 17, 2023
@tekton-robot
Copy link
Collaborator

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/apis/resource/v1alpha1/pipelineresource_validation.go 88.9% 93.8% 4.9

@tekton-robot
Copy link
Collaborator

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage-df to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/apis/resource/v1alpha1/pipelineresource_validation.go 88.9% 93.8% 4.9

@JeromeJu
Copy link
Member Author

/retest

@tekton-robot tekton-robot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Jan 17, 2023
@tekton-robot
Copy link
Collaborator

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/apis/resource/v1alpha1/pipelineresource_validation.go 88.9% 93.8% 4.9

@tekton-robot
Copy link
Collaborator

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage-df to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/apis/resource/v1alpha1/pipelineresource_validation.go 88.9% 93.8% 4.9

@tekton-robot
Copy link
Collaborator

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/apis/resource/v1alpha1/pipelineresource_validation.go 88.9% 93.8% 4.9

@tekton-robot
Copy link
Collaborator

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage-df to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/apis/resource/v1alpha1/pipelineresource_validation.go 88.9% 93.8% 4.9

@tekton-robot tekton-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 18, 2023
@JeromeJu JeromeJu force-pushed the rm-cluster-resources branch from 50c1dd3 to 3e96dcd Compare January 18, 2023 12:42
@tekton-robot
Copy link
Collaborator

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/apis/resource/v1alpha1/pipelineresource_validation.go 88.9% 93.8% 4.9

@tekton-robot
Copy link
Collaborator

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage-df to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/apis/resource/v1alpha1/pipelineresource_validation.go 88.9% 93.8% 4.9

@tekton-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lbernick, vdemeester

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [lbernick,vdemeester]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@Yongxuanzhang
Copy link
Member

/lgtm

@tekton-robot tekton-robot added lgtm Indicates that a PR is ready to be merged. and removed lgtm Indicates that a PR is ready to be merged. labels Jan 19, 2023
@JeromeJu
Remove Cluster pipelineResources
9eb987b 
This commit removes the Cluster Resources support.
This PR removes `github.com/tektoncd/pipeline/pkg/apis/resource/v1alpha1/cluster`
the kubeConfigWriter image and docs for cluseter resources.
Removal of `pipelineResources`, as in tektoncd#5967 has been broken up into removal
of each resources packages for the `small PR` code standard.
@JeromeJu JeromeJu force-pushed the rm-cluster-resources branch from 729ace6 to 9eb987b Compare January 19, 2023 18:03
@tekton-robot
Copy link
Collaborator

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/apis/resource/v1alpha1/pipelineresource_validation.go 88.9% 93.8% 4.9

@tekton-robot
Copy link
Collaborator

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage-df to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/apis/resource/v1alpha1/pipelineresource_validation.go 88.9% 93.8% 4.9

@Yongxuanzhang
Copy link
Member

/lgtm

@tekton-robot tekton-robot added the lgtm Indicates that a PR is ready to be merged. label Jan 19, 2023
@tekton-robot tekton-robot merged commit 9814fdd into tektoncd:main Jan 19, 2023
This was referenced Jan 25, 2023
Merged
Closed
Closed
Closed
Closed
@JordanGoasdoue JordanGoasdoue mentioned this pull request Jul 10, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vdemeester vdemeester vdemeester approved these changes

@lbernick lbernick lbernick approved these changes

@dibyom dibyom Awaiting requested review from dibyom

@pritidesai pritidesai Awaiting requested review from pritidesai

Assignees

@Yongxuanzhang Yongxuanzhang

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/misc Categorizes issue or PR as a miscellaneuous one. lgtm Indicates that a PR is ready to be merged. release-note-action-required Denotes a PR that introduces potentially breaking changes that require user action. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@JeromeJu @tekton-robot @Yongxuanzhang @vdemeester @lbernick