-
Notifications
You must be signed in to change notification settings - Fork 250
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove PipelineResource support and subcommands #1657
Comments
Actually, it is still there, so it's less of a priority than I though. |
I was a little worried when I saw this since the Dashboard still relies on PipelineResource support for its import functionality and I thought I had missed something in the recent Pipeline release notes 😅 Looks like it was only the v1alpha1 versions of the v1beta1 resources that were removed so we're OK for now… 😌 |
@AlanGreene yeah, I got confused by my own change ; long back I moved the PipelineResource go type to their own package, so when I looked this morning I was like "oh PipelineResource is gone from |
For the time being we can add deprecation flag/message for the pipelineresource command. |
/assign @piyush-garg |
This will mark pipelineresources related commands deprecated as it has been deprecated in pipeline long back and can get removed soon. we will also remove as it will get removed there Part of tektoncd#1657
This will mark pipelineresources related commands deprecated as it has been deprecated in pipeline long back and can get removed soon. we will also remove as it will get removed there Part of #1657
We have marked them deprecated some release ago, waiting for them to be removed in pipeline, we will do the same along with that |
Thank you for taking the precautions here! Since the |
/assign @pratap0007 |
@piyush-garg: GitHub didn't allow me to assign the following users: pratap0007. Note that only tektoncd members, repo collaborators and people who have commented on this issue/PR can be assigned. Additionally, issues/PRs can only have 10 assignees at the same time. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/assign |
As Pipelineresources have been removed in 0.46 pipeline so this patch removes inputresources and outputresources flag in tkn clustertask start command and updates unit test Closes part of : tektoncd#1657 Signed-off-by: Shiv Verma <[email protected]>
As Pipelineresources have been removed in 0.46 pipeline so this patch removes inputresources and outputresources flag in tkn clustertask start command and updates unit test Closes part of : #1657 Signed-off-by: Shiv Verma <[email protected]>
As Pipelineresources have been removed in 0.46 pipeline so this patch removes resource command Closes part of: tektoncd#1657 Signed-off-by: Shiv Verma <[email protected]>
As Pipelineresources have been removed in 0.46 pipeline so this patch removes resource command Closes part of: tektoncd#1657 Signed-off-by: Shiv Verma <[email protected]>
As Pipelineresources have been removed in 0.46 pipeline so this patch removes resource command Closes part of: tektoncd#1657 Signed-off-by: Shiv Verma <[email protected]>
As Pipelineresources have been removed in 0.46 pipeline so this patch removes resource command Closes part of: tektoncd#1657 Signed-off-by: Shiv Verma <[email protected]>
As Pipelineresources have been removed in 0.46 pipeline so this patch removes resource command Closes part of: tektoncd#1657 Signed-off-by: Shiv Verma <[email protected]>
As Pipelineresources have been removed in 0.46 pipeline so this patch removes resource command Closes part of: #1657 Signed-off-by: Shiv Verma <[email protected]>
As Pipelineresources have been removed in 0.46 pipeline so this patch removes input and output resource in the clustertask describe command Closes part of: tektoncd#1657 Signed-off-by: Shiv Verma <[email protected]>
As Pipelineresources have been removed in 0.46 pipeline so this patch removes input and output resource in the clustertask describe command Closes part of: tektoncd#1657 Signed-off-by: Shiv Verma <[email protected]>
As Pipelineresources have been removed in 0.46 pipeline so this patch removes input and output resource in the clustertask describe command Closes part of: #1657 Signed-off-by: Shiv Verma <[email protected]>
it is done in the main branch and will be available with 0.31 release |
/kind cleanup
PipelineResource is deprecated and is removed with the removal of v1alpha1, we need to remove it from
tkn
./assign
The text was updated successfully, but these errors were encountered: