Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove PipelineResource support and subcommands #1657

Closed
vdemeester opened this issue Jul 26, 2022 · 11 comments
Closed

Remove PipelineResource support and subcommands #1657

vdemeester opened this issue Jul 26, 2022 · 11 comments
Assignees
Labels
kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release.
Milestone

Comments

@vdemeester
Copy link
Member

/kind cleanup

PipelineResource is deprecated and is removed with the removal of v1alpha1, we need to remove it from tkn.

/assign

@tekton-robot tekton-robot added the kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. label Jul 26, 2022
@vdemeester vdemeester removed their assignment Jul 26, 2022
@vdemeester vdemeester added the priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete. label Jul 26, 2022
@vdemeester
Copy link
Member Author

Actually, it is still there, so it's less of a priority than I though.

@AlanGreene
Copy link
Member

I was a little worried when I saw this since the Dashboard still relies on PipelineResource support for its import functionality and I thought I had missed something in the recent Pipeline release notes 😅 Looks like it was only the v1alpha1 versions of the v1beta1 resources that were removed so we're OK for now… 😌

@vdemeester
Copy link
Member Author

@AlanGreene yeah, I got confused by my own change ; long back I moved the PipelineResource go type to their own package, so when I looked this morning I was like "oh PipelineResource is gone from v1alpha1".. but ain't true 😹. It's just in a different package 🙃

@piyush-garg piyush-garg added this to the 0.26.0 milestone Jul 26, 2022
@piyush-garg piyush-garg removed this from the 0.26.0 milestone Aug 26, 2022
@pradeepitm12
Copy link
Contributor

For the time being we can add deprecation flag/message for the pipelineresource command.

@pradeepitm12
Copy link
Contributor

/assign @piyush-garg

piyush-garg added a commit to piyush-garg/cli that referenced this issue Oct 10, 2022
This will mark pipelineresources related commands deprecated
as it has been deprecated in pipeline long back and can get
removed soon. we will also remove as it will get removed there

Part of tektoncd#1657
tekton-robot pushed a commit that referenced this issue Oct 10, 2022
This will mark pipelineresources related commands deprecated
as it has been deprecated in pipeline long back and can get
removed soon. we will also remove as it will get removed there

Part of #1657
@piyush-garg piyush-garg modified the milestones: 0.27.0, 0.29.0 Nov 23, 2022
@piyush-garg piyush-garg modified the milestones: 0.29.0, 0.30.0 Jan 5, 2023
@piyush-garg
Copy link
Contributor

We have marked them deprecated some release ago, waiting for them to be removed in pipeline, we will do the same along with that

@JeromeJu
Copy link
Member

Thank you for taking the precautions here!

Since the pipelineResources are going to be removed in pipeline v0.45 as designed in TEP074 and according to deprecation.md, (some have already been removed eg. cloudevent and cluster PipelineResources in v0.44), I think we might update the tag as important soon?

@vdemeester vdemeester added priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. and removed priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete. labels Jan 31, 2023
@piyush-garg piyush-garg modified the milestones: 0.30.0, 0.31.0 Mar 28, 2023
@piyush-garg
Copy link
Contributor

/assign @pratap0007

@tekton-robot
Copy link
Contributor

@piyush-garg: GitHub didn't allow me to assign the following users: pratap0007.

Note that only tektoncd members, repo collaborators and people who have commented on this issue/PR can be assigned. Additionally, issues/PRs can only have 10 assignees at the same time.
For more information please see the contributor guide

In response to this:

/assign @pratap0007

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@pratap0007
Copy link
Contributor

/assign

pratap0007 added a commit to pratap0007/cli that referenced this issue Apr 13, 2023
As Pipelineresources have been removed in 0.46 pipeline
so this patch removes inputresources and outputresources flag
in tkn clustertask start command and updates unit test

Closes part of : tektoncd#1657

Signed-off-by: Shiv Verma <[email protected]>
tekton-robot pushed a commit that referenced this issue Apr 13, 2023
As Pipelineresources have been removed in 0.46 pipeline
so this patch removes inputresources and outputresources flag
in tkn clustertask start command and updates unit test

Closes part of : #1657

Signed-off-by: Shiv Verma <[email protected]>
pratap0007 added a commit to pratap0007/cli that referenced this issue Apr 13, 2023
As Pipelineresources have been removed in 0.46 pipeline
so this patch removes resource command

Closes part of: tektoncd#1657

Signed-off-by: Shiv Verma <[email protected]>
pratap0007 added a commit to pratap0007/cli that referenced this issue Apr 13, 2023
As Pipelineresources have been removed in 0.46 pipeline
so this patch removes resource command

Closes part of: tektoncd#1657

Signed-off-by: Shiv Verma <[email protected]>
pratap0007 added a commit to pratap0007/cli that referenced this issue Apr 14, 2023
As Pipelineresources have been removed in 0.46 pipeline
so this patch removes resource command

Closes part of: tektoncd#1657

Signed-off-by: Shiv Verma <[email protected]>
pratap0007 added a commit to pratap0007/cli that referenced this issue Apr 14, 2023
As Pipelineresources have been removed in 0.46 pipeline
so this patch removes resource command

Closes part of: tektoncd#1657

Signed-off-by: Shiv Verma <[email protected]>
pratap0007 added a commit to pratap0007/cli that referenced this issue Apr 14, 2023
As Pipelineresources have been removed in 0.46 pipeline
so this patch removes resource command

Closes part of: tektoncd#1657

Signed-off-by: Shiv Verma <[email protected]>
tekton-robot pushed a commit that referenced this issue Apr 14, 2023
As Pipelineresources have been removed in 0.46 pipeline
so this patch removes resource command

Closes part of: #1657

Signed-off-by: Shiv Verma <[email protected]>
pratap0007 added a commit to pratap0007/cli that referenced this issue Apr 14, 2023
As Pipelineresources have been removed in 0.46 pipeline
so this patch removes input and output resource in the
clustertask describe command

Closes part of: tektoncd#1657

Signed-off-by: Shiv Verma <[email protected]>
pratap0007 added a commit to pratap0007/cli that referenced this issue Apr 14, 2023
As Pipelineresources have been removed in 0.46 pipeline
so this patch removes input and output resource in the
clustertask describe command

Closes part of: tektoncd#1657

Signed-off-by: Shiv Verma <[email protected]>
tekton-robot pushed a commit that referenced this issue Apr 14, 2023
As Pipelineresources have been removed in 0.46 pipeline
so this patch removes input and output resource in the
clustertask describe command

Closes part of: #1657

Signed-off-by: Shiv Verma <[email protected]>
@piyush-garg
Copy link
Contributor

it is done in the main branch and will be available with 0.31 release

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release.
Projects
Status: Todo
Development

No branches or pull requests

7 participants