Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pin knative/pkg to 1.8 #5661

Merged
merged 1 commit into from
Oct 19, 2022
Merged

Pin knative/pkg to 1.8 #5661

merged 1 commit into from
Oct 19, 2022

Conversation

vdemeester
Copy link
Member

Changes

This pin the dependency to the 1.8 release of knative instead of a
commit in main.

The commit (knative/pkg@8178c38)
that #5643 required is available in 1.8 (see https://github.com/knative/pkg/commits/release-1.8)

Signed-off-by: Vincent Demeester [email protected]

/kind misc

Submitter Checklist

As the author of this PR, please check off the items in this checklist:

  • Has Docs included if any changes are user facing
  • Has Tests included if any functionality added or changed
  • Follows the commit message standard
  • Meets the Tekton contributor standards (including
    functionality, content, code)
  • Has a kind label. You can add one by adding a comment on this PR that contains /kind <type>. Valid types are bug, cleanup, design, documentation, feature, flake, misc, question, tep
  • Release notes block below has been updated with any user facing changes (API changes, bug fixes, changes requiring upgrade notices or deprecation warnings)
  • Release notes contains the string "action required" if the change requires additional action from users switching to the new release

Release Notes

NONE

@tekton-robot tekton-robot added kind/misc Categorizes issue or PR as a miscellaneuous one. release-note-none Denotes a PR that doesnt merit a release note. labels Oct 19, 2022
@tekton-robot tekton-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Oct 19, 2022
@vdemeester
Copy link
Member Author

cc @afrittoli @imjasonh @abayer

afrittoli
afrittoli reviewed Oct 19, 2022
View reviewed changes
Copy link
Member

@afrittoli afrittoli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Being on a specific release makes it easier to pull in patch releases, so +1 on this.

/approve

go.mod
@@ -34,7 +34,7 @@ require (
k8s.io/code-generator v0.25.2
k8s.io/klog v1.0.0
k8s.io/kube-openapi v0.0.0-20220803162953-67bda5d908f1
knative.dev/pkg v0.0.0-20221014164553-b812affa3893
knative.dev/pkg v0.0.0-20221011175852-714b7630a836
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

NIT: It would be nice to have a comment in here so we know it's 1.8?

@tekton-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: afrittoli

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tekton-robot tekton-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 19, 2022
@lbernick
Copy link
Member

Being on a specific release makes it easier to pull in patch releases, so +1 on this.

What's the reason this is easier out of curiosity? also does this line need to be updated?

@vdemeester
Copy link
Member Author

Being on a specific release makes it easier to pull in patch releases, so +1 on this.

What's the reason this is easier out of curiosity? also does this line need to be updated?

Oh very good point, it needs to.. I forgot to commit that file.. 🤦🏼

@vdemeester
Pin knative/pkg to 1.8
9bd07d4 
This pin the dependency to the 1.8 release of knative instead of a
commit in main.

The commit (knative/pkg@8178c38)
that tektoncd#5643 required is available in 1.8 (see https://github.com/knative/pkg/commits/release-1.8)

Signed-off-by: Vincent Demeester <[email protected]>
@lbernick
Copy link
Member

/lgtm

@tekton-robot tekton-robot added the lgtm Indicates that a PR is ready to be merged. label Oct 19, 2022
@tekton-robot tekton-robot merged commit eb45fb0 into tektoncd:main Oct 19, 2022
@vdemeester vdemeester deleted the knative-1.8 branch October 20, 2022 08:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@afrittoli afrittoli afrittoli left review comments

@bobcatfish bobcatfish Awaiting requested review from bobcatfish

@lbernick lbernick Awaiting requested review from lbernick

Assignees

@lbernick lbernick

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/misc Categorizes issue or PR as a miscellaneuous one. lgtm Indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesnt merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@vdemeester @tekton-robot @lbernick @afrittoli