Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bump knative.dev/pkg dep to latest #5643

Merged
merged 1 commit into from
Oct 18, 2022
Merged

bump knative.dev/pkg dep to latest #5643

merged 1 commit into from
Oct 18, 2022

Conversation

k4leung4
Copy link
Contributor

@k4leung4 k4leung4 commented Oct 14, 2022 •
edited by imjasonh
Loading

Signed-off-by: Kenny Leung [email protected]

Changes

Submitter Checklist

As the author of this PR, please check off the items in this checklist:

  • Has Docs included if any changes are user facing
  • Has Tests included if any functionality added or changed
  • Follows the commit message standard
  • Meets the Tekton contributor standards (including
    functionality, content, code)
  • Has a kind label. You can add one by adding a comment on this PR that contains /kind <type>. Valid types are bug, cleanup, design, documentation, feature, flake, misc, question, tep
  • Release notes block below has been updated with any user facing changes (API changes, bug fixes, changes requiring upgrade notices or deprecation warnings)
  • Release notes contains the string "action required" if the change requires additional action from users switching to the new release

Release Notes

Update knative.dev/pkg dependency for support of k8s 1.25.x

@tekton-robot tekton-robot added the do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. label Oct 14, 2022
@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Oct 14, 2022 •
edited
Loading

CLA Signed

The committers listed above are authorized under a signed CLA.

  • ✅ login: k4leung4 / name: Kenny Leung (ac6fa5d)

@tekton-robot tekton-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Oct 14, 2022
@tekton-robot
Copy link
Collaborator

Hi @k4leung4. Thanks for your PR.

I'm waiting for a tektoncd member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@tekton-robot tekton-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Oct 14, 2022
@k4leung4
Copy link
Contributor Author

/kind cleanup

@tekton-robot tekton-robot added the kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. label Oct 14, 2022
@imjasonh
Copy link
Member

/lgtm

@tekton-robot tekton-robot added the lgtm Indicates that a PR is ready to be merged. label Oct 17, 2022
@wlynch
Copy link
Member

wlynch commented Oct 17, 2022

/remove-kind cleanup

@tekton-robot tekton-robot removed the kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. label Oct 17, 2022
@wlynch
Copy link
Member

wlynch commented Oct 17, 2022

/kind cleanup

@tekton-robot tekton-robot added the kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. label Oct 17, 2022
@wlynch
Copy link
Member

wlynch commented Oct 17, 2022

/ok-to-test

@tekton-robot tekton-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Oct 17, 2022
@imjasonh
Copy link
Member

/ok-to-test

@tekton-robot tekton-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Oct 17, 2022
@wlynch wlynch mentioned this pull request Oct 17, 2022
Merged
7 tasks
@tekton-robot tekton-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Oct 17, 2022
@imjasonh
Copy link
Member

/lgtm

@tekton-robot tekton-robot added the lgtm Indicates that a PR is ready to be merged. label Oct 17, 2022
@tekton-robot tekton-robot removed the lgtm Indicates that a PR is ready to be merged. label Oct 18, 2022
afrittoli
afrittoli reviewed Oct 18, 2022
View reviewed changes
docs/pipeline-api.md Outdated
@@ -6745,7 +6745,7 @@ Resource Types:
<div>
<p>ClusterTask is a Task with a cluster scope. ClusterTasks are used to
represent Tasks that should be publicly addressable from any namespace in the
cluster.</p>
cluster. Deprecated: Please use the cluster resolver instead.</p>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change seems unrelated to the PR?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

reverted.

@imjasonh
Copy link
Member

/lgtm

@tekton-robot tekton-robot added the lgtm Indicates that a PR is ready to be merged. label Oct 18, 2022
@vdemeester
Copy link
Member

@k4leung4 can you squash your commits ? 👼🏼

@tekton-robot tekton-robot removed the lgtm Indicates that a PR is ready to be merged. label Oct 18, 2022
@k4leung4
bump knative.dev/pkg dep to latest
01ceadd 
Signed-off-by: Kenny Leung <[email protected]>

codegen

Signed-off-by: Kenny Leung <[email protected]>

go mod vendor

Signed-off-by: Kenny Leung <[email protected]>

update-codegen

Signed-off-by: Kenny Leung <[email protected]>

fix

Signed-off-by: Kenny Leung <[email protected]>

fix vendor

Signed-off-by: Kenny Leung <[email protected]>
@vdemeester
Copy link
Member

/approve

@tekton-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: vdemeester

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tekton-robot tekton-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 18, 2022
@imjasonh
Copy link
Member

/lgtm

@tekton-robot tekton-robot added the lgtm Indicates that a PR is ready to be merged. label Oct 18, 2022
@k4leung4
Copy link
Contributor Author

/retest-required

@tekton-robot tekton-robot merged commit ac8da46 into tektoncd:main Oct 18, 2022
@k4leung4 k4leung4 deleted the kpkg branch October 18, 2022 16:39
vdemeester added a commit to vdemeester/tektoncd-pipeline that referenced this pull request Oct 19, 2022
@vdemeester
Pin knative/pkg to 1.8
26e001f 
This pin the dependency to the 1.8 release of knative instead of a
commit in main.

The commit (knative/pkg@8178c38)
that tektoncd#5643 required is available in 1.8 (see https://github.com/knative/pkg/commits/release-1.8)

Signed-off-by: Vincent Demeester <[email protected]>
@vdemeester vdemeester mentioned this pull request Oct 19, 2022
Merged
7 tasks
vdemeester added a commit to vdemeester/tektoncd-pipeline that referenced this pull request Oct 19, 2022
@vdemeester
Pin knative/pkg to 1.8
9bd07d4 
This pin the dependency to the 1.8 release of knative instead of a
commit in main.

The commit (knative/pkg@8178c38)
that tektoncd#5643 required is available in 1.8 (see https://github.com/knative/pkg/commits/release-1.8)

Signed-off-by: Vincent Demeester <[email protected]>
tekton-robot pushed a commit that referenced this pull request Oct 19, 2022
@vdemeester @tekton-robot
Pin knative/pkg to 1.8
eb45fb0 
This pin the dependency to the 1.8 release of knative instead of a
commit in main.

The commit (knative/pkg@8178c38)
that #5643 required is available in 1.8 (see https://github.com/knative/pkg/commits/release-1.8)

Signed-off-by: Vincent Demeester <[email protected]>
JeromeJu pushed a commit to JeromeJu/pipeline that referenced this pull request Oct 24, 2022
@vdemeester @JeromeJu
Pin knative/pkg to 1.8
c98e63e 
This pin the dependency to the 1.8 release of knative instead of a
commit in main.

The commit (knative/pkg@8178c38)
that tektoncd#5643 required is available in 1.8 (see https://github.com/knative/pkg/commits/release-1.8)

Signed-off-by: Vincent Demeester <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@afrittoli afrittoli afrittoli left review comments

@imjasonh imjasonh Awaiting requested review from imjasonh

@jerop jerop Awaiting requested review from jerop

Assignees

@imjasonh imjasonh

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm Indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@k4leung4 @tekton-robot @imjasonh @wlynch @vdemeester @afrittoli