Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[release-v0.36.x] Fix the issue with empty array replacement #5442

Merged
merged 2 commits into from
Sep 7, 2022
Merged

[release-v0.36.x] Fix the issue with empty array replacement #5442

merged 2 commits into from
Sep 7, 2022

Conversation

tekton-robot
Copy link
Collaborator

This is an automated cherry-pick of #5394

/assign afrittoli

After the replacement with an empty array, the original array will be empty.

Example:
---
params:
  - name: myarray
     value: "$(params.anEmptyArray[*])"

@vdemeester
Fix the issue with empty array replacement
4b78091 
Prior to this change, if there is only one element in an array that is
a reference to an empty array, the original array becomes nil after
replacement, but it should be an empty array instead of nil.

Fixes tektoncd#5149

Signed-off-by: Vincent Demeester <[email protected]>
@vdemeester
Add // #nosec :)
8595357 
Signed-off-by: Vincent Demeester <[email protected]>
@tekton-robot tekton-robot added the release-note Denotes a PR that will be considered when it comes time to generate release notes. label Sep 6, 2022
@tekton-robot tekton-robot mentioned this pull request Sep 6, 2022
Merged
7 tasks
@tekton-robot tekton-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Sep 6, 2022
@tekton-robot
Copy link
Collaborator Author

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/apis/pipeline/v1beta1/param_types.go 98.1% 97.4% -0.7
pkg/pod/creds_init.go 93.9% 93.3% -0.5

@abayer
Copy link
Contributor

abayer commented Sep 6, 2022

/kind bug

@tekton-robot tekton-robot added the kind/bug Categorizes issue or PR as related to a bug. label Sep 6, 2022
@tekton-robot
Copy link
Collaborator Author

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jerop

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tekton-robot tekton-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 7, 2022
@abayer
Copy link
Contributor

abayer commented Sep 7, 2022

/retest
/lgtm

@tekton-robot tekton-robot added the lgtm Indicates that a PR is ready to be merged. label Sep 7, 2022
@tekton-robot tekton-robot merged commit f316a2d into tektoncd:release-v0.36.x Sep 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jerop jerop jerop approved these changes

@imjasonh imjasonh Awaiting requested review from imjasonh

@pritidesai pritidesai Awaiting requested review from pritidesai

Assignees

@abayer abayer

@afrittoli afrittoli

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/bug Categorizes issue or PR as related to a bug. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@tekton-robot @abayer @jerop @afrittoli @vdemeester